Add sri #1233
Merged
Add sri #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flagging as DNM while we investigate an issue with older versions of firefox (see https://github.com/alphagov/government-frontend#368) |
|
See alphagov/govuk_template#308 and alphagov/govuk_template#301 for discussion on impact. We're holding off on SRI until there are fewer users using the version of Firefox that has an issue with calculating SRI. |
We want a version that targets sprockets 3 and also provides support for calculating sub-resource integrity (SRI) attributes on linked assets.
We rely on sprockets-rails to do the heavy lifting for us here and calculate the integrity sha for these assets. We also add th ecrossorigin attribute set to 'anonymous' because our assets are served from a different domain to the main application (assets.publishing.service.gov.uk vs www.gov.uk in most cases) and so to avoid dealing with CORS we tell the browser to not send CORS headers with the request for the asset.
This brings with it sprockets-rails 3.x compatibility by adding hogan.js to assets.precompile. This may only be a problem on development as we only make the render_mustache call in that rails env.
|
Removed DNM and rebased, this is ready to go now as we've solved the issue with SRI on firefox (see https://trello.com/c/UcJJBH0k/183-investigate-bom-issue-with-asset-compilation) and are slowly rolling SRI out across our apps. |
NickColley
approved these changes
Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://trello.com/c/b3FnLalV/148-enable-subresource-integrity-sri-on-frontend-s
This only adds SRI attributes to the assets delivered as part of frontend itself; JS and CSS delivered by templates included from static require SRI to be added by static itself (see: alphagov/static#1008 for work in this area).
Local testing can be achieved by setting
config.assets.debug = falseinconfig/development.rbas sprockets-rails doesn't do integrity calculations in dev mode otherwise.