Revert #301 Add SRI #308
Merged
Revert #301 Add SRI #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2017
fofr
reviewed
May 22, 2017
|
|
||
| <!--[if IE 8]><link href="<%= asset_path "fonts-ie8.css" %>" media="all" rel="stylesheet" /><![endif]--> | ||
| <!--[if gte IE 9]><!--><%= stylesheet_link_tag "fonts.css", media: "all", integrity: true, crossorigin: "anonymous" %><!--<![endif]--> | ||
| <!--[if gte IE 9]><!--><%= stylesheet_link_tag "fonts.css", media: "all", integrity: true, crossorigin: "anonymous" %><!--<![endif]--> |
There was a problem hiding this comment.
Looks like this was duplicated accidentally in original?
fofr
suggested changes
May 22, 2017
| <!--[if gte IE 9]><!--><%= stylesheet_link_tag "fonts.css", media: "all", integrity: true, crossorigin: "anonymous" %><!--<![endif]--> | ||
| <!--[if lt IE 9]><%= javascript_include_tag "ie.js", integrity: true, crossorigin: "anonymous" %><![endif]--> | ||
| <!--[if gte IE 9]><!--><link href="<%= asset_path "fonts.css" %>" media="all" rel="stylesheet" /><!--<![endif]--> | ||
| <!--[if lt IE 9]><script src="<% asset_path "ie.js" %>"></script><![endif]--> |
There was a problem hiding this comment.
asset_path is missing an equals here, should be: <%=
There was a problem hiding this comment.
Spotted via this comparison: 10d2348...revert-add-sri
There was a problem hiding this comment.
oops. I blame having to make this change 4 times because I kept editing the built version instead of the source! Thanks for spotting.
This is a manual revert, as the PR could not be reverted automatically. We're reverting this PR because there is a bug in the SRI implementation of Firefox versions upto 52 which at time of writing accounts for 0.7% of total traffic (~315k users). We still want to implement SRI, but for now we're holding off until we'd impact fewer users.
fofr
approved these changes
May 22, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual revert of #301, as the PR could not be reverted automatically.
We're reverting this PR because there is a bug in the SRI implementation
of Firefox versions upto 52 which at time of writing accounts for 0.7% of
total traffic (~315k users). We still want to implement SRI, but for now
we're holding off until we'd impact fewer users.