Filter panel UI tweaks #3466
Merged
Filter panel UI tweaks #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GOV.UK Frontend radio and checkboxes are rendered with a transparent background, which makes them look wrong on this component's grey background. This is intentional in GOV.UK Frontend and unlikely to change (see alphagov/govuk-frontend#1625).
There was a stray space at the beginning of the button element which was causing the underline to cover more than just the text. This removes it and increases the chevron margin instead.
csutter
force-pushed
the
filter-panel-tweaks
branch
from
2a7f0ab to
c419224
Compare
The filter panel is always supposed to have a bottom border, but currently relies on the top border of the document list following it for its border. This gives the panel its own border so it's present even if there is no document list following it, and accordingly removes it from the top of the first document list item on the new all content finder view.
alexbowen
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background, which makes them look wrong on this component's grey background. This is intentional in GOV.UK Frontend and unlikely to
change (see Why do checkboxes and radios have transparent backgrounds? govuk-frontend#1625).
Before
After