Filter panel: Fix hover underline

There was a stray space at the beginning of the button element which was causing the underline to cover more than just the text. This removes it and increases the chevron margin instead.
alphagov · Sep 20, 2024 · 2a7f0ab · 2a7f0ab
1 parent c921d75
commit 2a7f0ab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/app/assets/stylesheets/components/_filter-panel.scss b/app/assets/stylesheets/components/_filter-panel.scss
@@ -48,7 +48,7 @@
   }
 
   &::before {
-    margin: 0 govuk-spacing(2) govuk-spacing(1) 0;
+    margin: 0 govuk-spacing(3) govuk-spacing(1) 0;
   }
 }
 

diff --git a/app/views/components/_filter_panel.html.erb b/app/views/components/_filter_panel.html.erb
@@ -24,9 +24,7 @@
       id: button_id,
       class: "app-c-filter-panel__button govuk-link",
       aria: { expanded: "false", controls: panel_content_id }
-    ) do %>
-      <%= button_text %>
-    <% end %>
+    ) { button_text } %>
 
     <% if result_text.present? %>
       <%= content_tag("h2", class: "app-c-filter-panel__count") do %>
-Original file line number
+Diff line change
@@ Expand Up / @@ -48,7 +48,7 @@ @@
       }
       &::before {
-        margin: 0 govuk-spacing(2) govuk-spacing(1) 0;
+        margin: 0 govuk-spacing(3) govuk-spacing(1) 0;
       }
     }
@@ Expand Down @@