-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade components gem #1307
Upgrade components gem #1307
Conversation
d836678
to
caee7c0
Compare
9d447ca
to
9884632
Compare
9884632
to
73fb0e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two suggestions otherwise good to go.
73fb0e3
to
31e3758
Compare
@injms niiiiiiiice |
31e3758
to
3bb7cfc
Compare
@vanitabarrett yes, that's tied into that whole issue. @injms made some changes to related links but there are many other components affected. I'll take a look at the document list component and maybe put a checklist on that issue so we can keep track of what's been fixed. |
@alex-ju @vanitabarrett @injms @DilwoarH @maxgds just realised I can't merge this until we've done at least |
Updates the components gem in
finder-frontend
to version 18, which includes GOVUK Frontend V3, which includes breaking changes. This PR fixes those breaking changes.Visual changes
Changes to the option select component due to focus change styles. Before (focussed):
After (focussed):
(thanks to @injms for the style suggestion!)
The expander component has similar focus style changes, but as it's not in use anywhere I'm less worried about it.
Shouldn't be any other visual changes, I've looked through a load of finders and they all look like they used to.
Search page examples to sanity check:
Other finders