Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 focus style slightly overlaps text where line height and spacing are low #1028

Closed
7 of 8 tasks
andysellick opened this issue Aug 8, 2019 · 3 comments · Fixed by #1054 or #1085
Closed
7 of 8 tasks

V3 focus style slightly overlaps text where line height and spacing are low #1028

andysellick opened this issue Aug 8, 2019 · 3 comments · Fixed by #1054 or #1085

Comments

@andysellick
Copy link
Contributor

andysellick commented Aug 8, 2019

Some components have links closely spaced or links that can wrap onto a second line. With the new V3 focus styles this can cause some minor text cropping/overlapping issues, specifically:

Text beneath focussed link is too close:

Screen Shot 2019-08-07 at 11 06 00

Text wrapped onto a second line causes the lower part of some letters in the first line to be cut off:

Screen Shot 2019-08-06 at 13 21 54

Components to fix:

  • image card
  • attachment
  • textarea
  • metadata
  • organisation logo
  • related navigation
  • document list
  • possibly others?

This issue should be addressed after the V3 PR has been merged.

@injms
Copy link
Contributor

injms commented Aug 12, 2019

I'll take a look at this, since it's blocking a release on government-frontend.

@andysellick
Copy link
Contributor Author

Interestingly this issue is noticeable on the Design System website.

@NickColley
Copy link
Contributor

Perhaps we should consider removing the upper focus style padding? Would be good to know the different circumstances that this appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants