Upgrade to govuk frontend 5.1 #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
changed the title
Closed
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
45999be to
89cb177
Compare
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
89cb177 to
ffb32a3
Compare
MartinJJones
changed the title
andysellick
approved these changes
Jul 8, 2024
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
ffb32a3 to
a5eaf49
Compare
To prevent browsers evaluating JS that isn't supported, components that contain code from govuk-frontend have been moved to a separate file `es6-components.js` which is included in `application.html.erb` as a script tag with `type="module"`.
AshGDS
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
61dfd23 to
9f123cd
Compare
MartinJJones
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move components that rely on govuk-frontend modules to separate
es6-components.jsfileWhy
In the event that a browser below the target for
govuk-frontendloads a page with JS on it, attempting to parse the JS fromgovuk-frontendwill cause an error. To avoid this from happening, JS that containsgovuk-frontendJS has been moved to separate file which will be loaded in a script tag withtype="module". This will prevent the JS from being parsed and so prevent the errorTrello
The intention is for the PR to include the upgrade to the version of the publishing_components_gem as well, once released.