Move Javascript modules to es6-components

To prevent browsers evaluating JS that isn't supported, components that contain code from govuk-frontend have been moved to a separate file `es6-components.js` which is included in `application.html.erb` as a script tag with `type="module"`.
alphagov · Jul 5, 2024 · ffb32a3 · ffb32a3
1 parent 0b7cb78
commit ffb32a3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/app/assets/config/manifest.js b/app/assets/config/manifest.js
@@ -1,3 +1,4 @@
 //= link application.js
+//= link es6-components.js
 
 //= link_tree ../builds
diff --git a/app/assets/javascripts/application.js b/app/assets/javascripts/application.js
@@ -1,4 +1,2 @@
 //= require govuk_publishing_components/lib
 //= require govuk_publishing_components/components/details
-//= require govuk_publishing_components/components/error-summary
-//= require govuk_publishing_components/components/radio
diff --git a/app/assets/javascripts/es6-components.js b/app/assets/javascripts/es6-components.js
@@ -0,0 +1,2 @@
+//= require govuk_publishing_components/components/error-summary
+//= require govuk_publishing_components/components/radio
diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
@@ -43,5 +43,6 @@
   <body class="govuk-template__body">
     <%= yield :body %>
     <%= javascript_include_tag 'application' %>
+    <%= javascript_include_tag "es6-components", type: "module" %>
   </body>
 </html>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		//= require govuk_publishing_components/components/error-summary
		//= require govuk_publishing_components/components/radio