Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Allure Mocha ESM parallel; add deprecation warnings to the legacy API #995

Merged
merged 9 commits into from
Jun 7, 2024
1 change: 1 addition & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ module.exports = {
warnOnUnsupportedTypeScriptVersion: false,
},
plugins: ["n", "no-null", "prefer-arrow", "import", "jsdoc", "@typescript-eslint"],
ignorePatterns: ["**/dist/**/*"],
rules: {
"@typescript-eslint/ban-ts-comment": "off",
"@typescript-eslint/adjacent-overload-signatures": "error",
Expand Down
139 changes: 139 additions & 0 deletions .pnp.cjs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
16 changes: 16 additions & 0 deletions packages/allure-mocha/.eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,20 @@ module.exports = {
parserOptions: {
project: ["./tsconfig.json", "./tsconfig.test.json"],
},
overrides: [
{
files: ["**/*.cjs", "**/*.js"],
rules: {
"@typescript-eslint/no-require-imports": "off",
"@typescript-eslint/no-var-requires": "off",
},
},
{
files: ["./test/fixtures/samples/**/*.js", "./test/fixtures/runner.js"],
rules: {
"no-undef": "off",
"@typescript-eslint/no-unsafe-argument": "off",
},
},
],
};
2 changes: 1 addition & 1 deletion packages/allure-mocha/babel.cjs.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
],
["@babel/preset-env", { "modules": "commonjs" }]
],
"plugins": ["babel-plugin-add-module-exports"],
"plugins": ["babel-plugin-add-module-exports", "babel-plugin-transform-import-meta"],
"targets": {
"esmodules": false,
"node": 18
Expand Down
6 changes: 5 additions & 1 deletion packages/allure-mocha/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@
"lint:fix": "eslint ./src ./test --ext .ts --fix",
"test": "run-s 'test:*'",
"test:serial": "vitest run",
"test:parallel": "ALLURE_MOCHA_TEST_PARALLEL=true vitest run"
"test:parallel": "ALLURE_MOCHA_TEST_PARALLEL=true vitest run",
"test:runner": "ALLURE_MOCHA_TEST_RUNNER=cjs ALLURE_MOCHA_TEST_SPEC_FORMAT=cjs vitest run",
"test:runner-parallel": "ALLURE_MOCHA_TEST_RUNNER=esm ALLURE_MOCHA_TEST_SPEC_FORMAT=esm ALLURE_MOCHA_TEST_PARALLEL=true vitest run"
},
"dependencies": {
"allure-js-commons": "workspace:*"
Expand All @@ -67,6 +69,7 @@
"@typescript-eslint/eslint-plugin": "^7.0.0",
"@typescript-eslint/parser": "^7.0.0",
"babel-plugin-add-module-exports": "^1.0.4",
"babel-plugin-transform-import-meta": "^2.2.1",
"chai": "^4.3.8",
"chai-like": "^1.1.1",
"chai-things": "^0.2.0",
Expand All @@ -77,6 +80,7 @@
"eslint-plugin-n": "^17.0.0",
"eslint-plugin-no-null": "^1.0.2",
"eslint-plugin-prefer-arrow": "^1.2.3",
"glob": "^10.4.1",
"mocha": "^10.2.0",
"npm-run-all2": "^6.1.2",
"rimraf": "^5.0.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const {
EVENT_HOOK_END,
} = Mocha.Runner.constants;

export class MochaAllureReporter extends Mocha.reporters.Base {
export class AllureMochaReporter extends Mocha.reporters.Base {
private readonly runtime: ReporterRuntime;

constructor(runner: Mocha.Runner, opts: Mocha.MochaOptions) {
Expand Down
4 changes: 2 additions & 2 deletions packages/allure-mocha/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { MochaAllureReporter } from "./MochaAllureReporter.js";
import { AllureMochaReporter } from "./AllureMochaReporter.js";

export default MochaAllureReporter;
export default AllureMochaReporter;
Loading
Loading