Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Allure Mocha ESM parallel; add deprecation warnings to the legacy API #995

Merged
merged 9 commits into from
Jun 7, 2024

Conversation

delatrie
Copy link
Collaborator

@delatrie delatrie commented Jun 6, 2024

Context

Some fixes for Allure Mocha:

  • Fix the ESM version in parallel mode: now import.meta is used instead of __dirname. The babel-plugin-transform-import-meta plugin is used to transpile that construct to CommonJS.
  • deprecation warnings were added to the legacy API
  • MochaAllureReporter was renamed to AllureMochaReporter
  • runtime.ts was removed (it's not in use now)

Test improvements for Allure Mocha:

  • switching between esm and cjs samples (controlled by ALLURE_MOCHA_TEST_SPEC_FORMAT, the default is esm).
  • switching between the CLI and code runners, where the code runner can be in the esm or cjs format (controlled by ALLURE_MOCHA_TEST_RUNNER, the default is cli).

Linting fixes:

  • dist folders were removed from ESLint globally
  • no-require rules were disabled for Allure Mocha CommonJS files

Checklist

@github-actions github-actions bot added the theme:mocha Mocha related issue label Jun 6, 2024
@delatrie delatrie added the type:improvement Improvement or request label Jun 6, 2024
@delatrie delatrie force-pushed the mocha-fixes branch 4 times, most recently from 1f45c41 to d1179c4 Compare June 6, 2024 11:55
@delatrie delatrie marked this pull request as ready for review June 6, 2024 11:55
@delatrie delatrie merged commit 3576731 into main Jun 7, 2024
8 checks passed
@delatrie delatrie deleted the mocha-fixes branch June 7, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:mocha Mocha related issue type:improvement Improvement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants