Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix jasmine type definitions #298

Merged
merged 1 commit into from
Aug 2, 2021
Merged

fix jasmine type definitions #298

merged 1 commit into from
Aug 2, 2021

Conversation

just-boris
Copy link
Contributor

Context

Currently the build in the master branch fails, because of changes in the @types/jasmine dependency. This PR fixes that

Checklist

@just-boris
Copy link
Contributor Author

This should not have happened in the first place. The project should not put package-lock.json files into .gitignore, this file protects against this kind of surprise changes

@just-boris just-boris mentioned this pull request Jul 17, 2021
Merged
@baev baev merged commit 75b3e22 into allure-framework:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev baev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@just-boris @baev