-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(allure-playwright): initial implementation for allure-playwright #297
Conversation
Hello! Thanks for the PR! There are known build failures, will be fixed soon #298 |
47164e3
to
40b7125
Compare
I added a couple more tests. |
Can we also add |
40b7125
to
4627c25
Compare
Done.
Done. |
Tell me if I should kick myself out of the owners for |
b03769b
to
0bcd133
Compare
Playwright v1.13 is out and I published this package as |
@baev good day. When will the changes be approved? |
@pavelfeldman could you please fix the build? |
You probably want to merge #298, otherwise current master is broken: allure-jasmine: test/label.test.ts(10,14): error TS2339: Property 'describe' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/label.test.ts(11,16): error TS2339: Property 'it' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/status.test.ts(10,15): error TS2339: Property 'describe' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/status.test.ts(11,17): error TS2339: Property 'it' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/status.test.ts(25,15): error TS2339: Property 'describe' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/status.test.ts(26,17): error TS2339: Property 'it' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/status.test.ts(40,15): error TS2339: Property 'describe' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/status.test.ts(41,17): error TS2339: Property 'xit' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/status.test.ts(55,15): error TS2339: Property 'xdescribe' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/status.test.ts(56,17): error TS2339: Property 'it' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/step.test.ts(10,15): error TS2339: Property 'describe' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/step.test.ts(11,17): error TS2339: Property 'it' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/step.test.ts(35,15): error TS2339: Property 'describe' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/step.test.ts(36,17): error TS2339: Property 'it' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/step.test.ts(74,15): error TS2339: Property 'describe' does not exist on type 'JasmineTestEnv'.
allure-jasmine: test/step.test.ts(75,17): error TS2339: Property 'it' does not exist on type 'JasmineTestEnv'. |
@baev ^^ |
478081e
to
638e433
Compare
It should build/test now, but mocha coverage fails for me locally... |
Fixed coverage in master, please rebase (also prettier/eslint config was added, please consider aligning code style as well) |
638e433
to
f91c9b6
Compare
Your eslint is quite unusual, but should be aligned now. |
|
f91c9b6
to
8c35d5d
Compare
8c35d5d
to
9da9409
Compare
@baev that test was running full Playwright and we need to install browser deps and/or include GH action for that. That's one line in yaml, but I removed the test for now to unblock it as is. |
@pavelfeldman @just-boris thanks! |
Fixes #296, microsoft/playwright#7034
This is initial implementation for Playwright reporter. I already booked
allure-playwright
npm package for it, please let me know who I should transfer ownership over it to. I did not push that package.Please let me know what you think about it and I can add more tests for it.