feat(contracts): update to cb95183 and add with_recommended_fillers() to examples where appropriate
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
commented
Apr 9, 2024
Comment on lines
46
to
48
| let contract_builder = Counter::deploy_builder(&provider); | ||
| let estimate = contract_builder.estimate_gas().await?; | ||
| let contract_address = | ||
| contract_builder.gas(estimate).gas_price(base_fee).nonce(0).deploy().await?; | ||
|
|
||
| println!("Deployed contract at address: {contract_address:?}"); | ||
| let contract_address = contract_builder.deploy().await?; | ||
| let contract = Counter::new(contract_address, provider); |
There was a problem hiding this comment.
Alternatively to be replaced by
Counter::deploy(&provider).await?;@prestwich this example, as is, throws the following error: missing properties: [("NonceManager", ["from"]), ("Signer", ["TODO"])] which is unexpected
Am I missing something or is this a bug?
There was a problem hiding this comment.
not a bug but work blocked by a PR. See the comment on the relevant code in the signer filler
There was a problem hiding this comment.
more specifically, Signer setting From and reporting kissing keys is blocked by refactor of tx builder
zerosnacks
commented
Apr 9, 2024
zerosnacks
changed the title
with_recommended_fillers() to examples where appropriatewith_recommended_fillers() to examples where appropriate
zerosnacks
commented
Apr 16, 2024
zerosnacks
changed the title
with_recommended_fillers() to examples where appropriatecb95183 and add with_recommended_fillers() to examples where appropriate
|
Appears that the PR closed itself when I changed the branch name to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Updates examples to be compatible with
cb95183(includes changes from alloy-rs/alloy#406)Closes #12 and fixes https://github.com/alloy-rs/examples/actions/runs/8608183386
Goal is an incremental improvement and compatibility
Solution
Supersedes: #33
PR Checklist