Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add GasFiller example to contracts and as gas_filler example in layers #12

Closed
zerosnacks opened this issue Mar 21, 2024 · 2 comments · Fixed by #50
Closed

[Feature] Add GasFiller example to contracts and as gas_filler example in layers #12

zerosnacks opened this issue Mar 21, 2024 · 2 comments · Fixed by #50
Assignees
@zerosnacks
Labels
enhancement New feature or request

Comments

@zerosnacks
Copy link
Member

zerosnacks commented Mar 21, 2024 •
edited
Loading

Context: #8 (comment)

Blocked by: alloy-rs/alloy#326

This is now unblocked: https://github.com/alloy-rs/alloy/blob/main/crates/provider/src/layers/gas.rs

Blocked by: alloy-rs/alloy#406

Now unblocked by alloy-rs/alloy#426
@zerosnacks zerosnacks self-assigned this Mar 21, 2024
@zerosnacks zerosnacks mentioned this issue Mar 21, 2024
Merged
@zerosnacks zerosnacks changed the title Add GasEstimationLayer to contracts examples Add GasEstimationLayer to contracts examples and as gas_layer example in layers Mar 25, 2024
@zerosnacks
Copy link
Member Author

I'm running into some limitations around CallBuilder not supporting (with)_chain_id() as GasLayer defaulting to EIP 1559 style transactions. It is also not clear if the nonce management takes contract deployments into account.

@DaniPopes
Copy link
Member

DaniPopes commented Mar 25, 2024 •
edited
Loading

wdym about CallBuilder? You can access the internal tx builder with .map

@zerosnacks zerosnacks changed the title Add GasEstimationLayer to contracts examples and as gas_layer example in layers [Feature] Add GasEstimationLayer to contracts examples and as gas_layer example in layers Mar 27, 2024
@zerosnacks zerosnacks mentioned this issue Mar 27, 2024
Closed
@zerosnacks zerosnacks added the enhancement New feature or request label Mar 28, 2024
@zerosnacks zerosnacks removed the blocked label Apr 9, 2024
@zerosnacks zerosnacks mentioned this issue Apr 9, 2024
Merged
2 tasks
@zerosnacks zerosnacks changed the title [Feature] Add GasEstimationLayer to contracts examples and as gas_layer example in layers [Feature] Add GasFiller example to contracts and as gas_filler example in layers Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zerosnacks zerosnacks

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@DaniPopes @zerosnacks