-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose Signature<T> #689
Conversation
While attempting to apply this refactoring to alloy itself, I start to understand why the I'm trying to find a workaround. |
@leruaa perhaps we can introduce a helper trait in alloy for the required rsv function and just that for the alloy encode signature fns instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would introduce a ton of friction
I agree the memoized type is a bit horribly, but we can probably solve our problems alloy internally by introducing a signature encodeable trait there so we can implement it for reth's signature type as well.
can deal with the generic signature snafu later
but perhaps we should consider removing the generic entirely, I find this very useless because this is effectively just duplicating the rsv again core/crates/primitives/src/signature/sig.rs Lines 301 to 305 in adcf7ad
|
@mattsse fyi and for posterity, the branch in alloy applying this refactoring in alloy-core: alloy-rs/alloy@main...leruaa:alloy:signature_refactoring |
Motivation
Needed for alloy-rs/alloy#1077 and paradigmxyz/reth#9593
Solution
PR Checklist