Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] allow any signature type for tx encoding #1077

Closed
mattsse opened this issue Jul 19, 2024 · 3 comments · Fixed by #1100
Closed

[Feature] allow any signature type for tx encoding #1077

mattsse opened this issue Jul 19, 2024 · 3 comments · Fixed by #1100
Assignees
Labels
enhancement New feature or request

Comments

@mattsse
Copy link
Member

mattsse commented Jul 19, 2024

Component

consensus, eips, genesis

Describe the feature you would like

these functions don't require a specific signature generic and can operate on Signature<S>

pub fn encoded_len_with_signature(&self, signature: &Signature) -> usize {

pub fn encode_with_signature_fields(
&self,
signature: &Signature,

we can keep the usage in the trait fn for now

fn into_signed(self, signature: Signature) -> Signed<Self> {

FYI @leruaa

Additional context

No response

@mattsse mattsse added the enhancement New feature or request label Jul 19, 2024
@leruaa
Copy link
Contributor

leruaa commented Jul 19, 2024

Thanks, taking this :)

@mattsse
Copy link
Member Author

mattsse commented Jul 19, 2024

as you already discovered, this needs an alloy-primitives change first

@leruaa
Copy link
Contributor

leruaa commented Jul 19, 2024

I started the alloy-primitives part: alloy-rs/core#689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants