Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Http::new for reqwest::Client #434

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat: add Http::new for reqwest::Client #434

merged 1 commit into from
Apr 5, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Apr 2, 2024 •
edited
Loading

Motivation

close #387

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

onbjerg
onbjerg approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg added the enhancement New feature or request label Apr 2, 2024
prestwich
prestwich requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@prestwich prestwich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this prevents us from using new to instantiate Http<hyper::Whatever>. I would rather match the pattern eslewhere in the repo new_hyper and new_reqwest

could we instead take this as a chance to address #397 ?

@nkysg
Copy link
Contributor Author

nkysg commented Apr 3, 2024 •
edited
Loading

this prevents us from using new to instantiate Httphyper::Whatever. I would rather match the pattern eslewhere in the repo new_hyperandnew_reqwest`

could we instead take this as a chance to address #397 ?

do you want to implement Http::new function ?

prestwich
prestwich approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this prevents us from using new to instantiate Httphyper::Whatever. I would rather match the pattern eslewhere in the repo new_hyper and new_reqwest

after #462 the naming convention is new and new_hyper so I'm approving this PR

@prestwich prestwich merged commit de7f9dd into alloy-rs:main Apr 5, 2024
18 checks passed
@nkysg nkysg deleted the http_new branch April 8, 2024 17:43
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@nkysg
feat: add Http::new for reqwest::Client (alloy-rs#434)
c05e881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add Http::new for reqwest::Client
3 participants
@nkysg @onbjerg @prestwich