Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Http::new for reqwest::Client #387

Closed
mattsse opened this issue Mar 24, 2024 · 1 comment · Fixed by #434
Closed

[Feature] Add Http::new for reqwest::Client #387

mattsse opened this issue Mar 24, 2024 · 1 comment · Fixed by #434
Labels
enhancement New feature or request

Comments

@mattsse
Copy link
Member

mattsse commented Mar 24, 2024

Component

rpc

Describe the feature you would like

the most commonly used http transport is reqwest::Client, currently it's required to provide the type:

let http = Http::<Client>::new(url);

this requires to always pull in reqwest.

I think it would be reasonable to move the new function to impl Http<reqwest::Client>, there is already Http::with_client that is sufficient for all other use cases.

Additional context

No response

@nkysg
Copy link
Contributor

nkysg commented Apr 2, 2024

I can try this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants