feat(layers): GasEstimationLayer #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
changed the title
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
gakonst
reviewed
Mar 15, 2024
gakonst
requested changes
Mar 15, 2024
|
Decided to make this a more generic tx builder layer. Ref: #326 (comment) Renaming it to |
This reverts commit 991968e.
yash-atreya
changed the title
Undo above. |
onbjerg
requested changes
Mar 19, 2024
prestwich
reviewed
Mar 20, 2024
prestwich
reviewed
Mar 20, 2024
prestwich
reviewed
Mar 20, 2024
prestwich
reviewed
Mar 20, 2024
prestwich
reviewed
Mar 20, 2024
prestwich
reviewed
Mar 20, 2024
|
Didn't see this getting merged #352 Fixing |
prestwich
requested changes
Mar 21, 2024
prestwich
reviewed
Mar 21, 2024
prestwich
reviewed
Mar 21, 2024
prestwich
approved these changes
Mar 21, 2024
gakonst
approved these changes
Mar 21, 2024
| } | ||
| Err(err) => { | ||
| if err.is_transport_error() | ||
| && err.to_string() == *"EIP-1559 not activated".to_string() |
There was a problem hiding this comment.
I'd love this to a helper method on the error re 1559 but we can do as followup
There was a problem hiding this comment.
actually this is a bit of a hole in the API. 1559 not activated should not be a transport error. "endpoint doesn't exist" falls in a hole between transport error and rpc error 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ref: #323
Solution
Implement a
layerthat populates thegas_price,gas,max_fee_per_gasandmax_priority_fee_per_gas.PR Checklist