Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modification: Eip1559Estimation return type #352

Merged
merged 2 commits into from
Mar 21, 2024
Merged

modification: Eip1559Estimation return type #352

merged 2 commits into from
Mar 21, 2024

Conversation

developeruche
Copy link
Contributor

Motivation

Closes #348

Solution

Create a Struct housing max_fee_per_gas and max_priority_fee_per_gas, this is the type that is returned by estimate_eip1559_fees fn.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

DaniPopes
DaniPopes approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit 4c6fe3c into alloy-rs:main Mar 21, 2024
16 checks passed
@yash-atreya yash-atreya mentioned this pull request Mar 21, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Make a struct return for estimate 1559
2 participants
@developeruche @DaniPopes