remove redundant auth privileges

[valentinyanakiev]

• removed redundant privileges
• auth reset is required after this is merged

WHITEBOARD_...._RT privileges are no longer relevant

Summary by CodeRabbit

• New Features

  • Streamlined authorization logic for collaboration by removing specific credential and privilege rules.

• Bug Fixes

  • Removed obsolete constants that were no longer utilized, ensuring a cleaner codebase and potentially reducing confusion for users.

[coderabbitai]

Walkthrough

This pull request includes the removal of specific constants and enum entries related to authorization rules within the codebase. The constants CREDENTIAL_RULE_TYPES_CALLOUT_SAVE_AS_TEMPLATE and POLICY_RULE_COLLABORATION_WHITEBOARD_CONTRIBUTORS_CREATE have been deleted from their respective files. Additionally, two entries, CREATE_WHITEBOARD_RT and SAVE_AS_TEMPLATE, have been removed from the AuthorizationPrivilege enum. These changes also affect the CollaborationAuthorizationService class, which no longer utilizes the removed constants or includes related logic for credential and privilege rules.

Changes

File Path	Change Summary
src/common/constants/authorization/credential.rule.types.constants.ts	Constant removed: CREDENTIAL_RULE_TYPES_CALLOUT_SAVE_AS_TEMPLATE
src/common/constants/authorization/policy.rule.constants.ts	Constant removed: POLICY_RULE_COLLABORATION_WHITEBOARD_CONTRIBUTORS_CREATE
src/common/enums/authorization.privilege.ts	Enum entries removed: CREATE_WHITEBOARD_RT, SAVE_AS_TEMPLATE
src/domain/collaboration/collaboration/collaboration.service.authorization.ts	Removed imports for constants and updated methods to eliminate rules for saving as a template and creating whiteboard contributors.

Possibly related PRs

• Add separate privilege for application approval #4655: This PR adds a new privilege related to application approval, which modifies the AuthorizationPrivilege enum and associated logic.
• fixed guard usage in XState machines; removed APPLICATION_ACCEPT which is equivalent to GRANT #4675: This PR removes the COMMUNITY_APPLY_ACCEPT privilege from the AuthorizationPrivilege enum, directly related to the changes in the main PR.
• [Technical] Remove unused privileges from AuthorizationPrivilege enum #4685: This PR also removes the COMMUNITY_APPLY_ACCEPT privilege from the AuthorizationPrivilege enum, reinforcing the changes made in the main PR.

Suggested reviewers

• techsmyth
• Comoque1

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9b5c8e6 and 2a069ce.

📒 Files selected for processing (4)

• src/common/constants/authorization/credential.rule.types.constants.ts (0 hunks)
• src/common/constants/authorization/policy.rule.constants.ts (0 hunks)
• src/common/enums/authorization.privilege.ts (0 hunks)
• src/domain/collaboration/collaboration/collaboration.service.authorization.ts (0 hunks)

💤 Files with no reviewable changes (4)

• src/common/constants/authorization/credential.rule.types.constants.ts
• src/common/constants/authorization/policy.rule.constants.ts
• src/common/enums/authorization.privilege.ts
• src/domain/collaboration/collaboration/collaboration.service.authorization.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.