also do auth reset after revoking a license plan

[techsmyth]

Summary by CodeRabbit

• New Features
  • Improved handling of license plans for accounts and spaces, ensuring clearer variable references.
• Bug Fixes
  • Enhanced authorization policy applications for assigning and revoking license plans.

[coderabbitai]

Walkthrough

The changes involve modifications to the AdminLicensingResolverMutations class in the licensing resolver file. Key updates include renaming variables for clarity, specifically changing account to space in methods related to assigning and revoking license plans. The handling of license plans for accounts and spaces has been adjusted to ensure that the correct entities are referenced in authorization policy applications and return statements.

Changes

Files	Change Summary
src/platform/admin/licensing/admin.licensing.resolver.mutations.ts	Renamed variables for clarity: account to space in relevant methods; adjusted authorization policy applications and return statements accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AdminLicensingResolverMutations

    User->>AdminLicensingResolverMutations: Assign License Plan to Space
    AdminLicensingResolverMutations->>AdminLicensingResolverMutations: assignLicensePlanToSpace(space)
    AdminLicensingResolverMutations->>AdminLicensingResolverMutations: applyAuthorizationPolicy(space)
    AdminLicensingResolverMutations-->>User: Return space

    User->>AdminLicensingResolverMutations: Revoke License Plan from Account
    AdminLicensingResolverMutations->>AdminLicensingResolverMutations: revokeLicensePlanFromAccount(account)
    AdminLicensingResolverMutations->>AdminLicensingResolverMutations: applyAuthorizationPolicy(account)
    AdminLicensingResolverMutations-->>User: Return account

    User->>AdminLicensingResolverMutations: Revoke License Plan from Space
    AdminLicensingResolverMutations->>AdminLicensingResolverMutations: revokeLicensePlanFromSpace(space)
    AdminLicensingResolverMutations->>AdminLicensingResolverMutations: applyAuthorizationPolicy(space)
    AdminLicensingResolverMutations-->>User: Return space

Loading

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 68b0894 and d2aee8f.

Files selected for processing (1)

• src/platform/admin/licensing/admin.licensing.resolver.mutations.ts (3 hunks)

Additional context used

Path-based instructions (1)

src/platform/admin/licensing/admin.licensing.resolver.mutations.ts (1)

Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs. Ensure that the code adheres to TypeScript's typing system and modern standards.

Additional comments not posted (4)

src/platform/admin/licensing/admin.licensing.resolver.mutations.ts (4)

94-103: LGTM!

The changes in this code segment are consistent and correct:

• The renaming of account to space aligns with the method's purpose.
• The applyAuthorizationPolicy method is correctly called with the space variable.
• The method correctly returns the space variable.

---

131-140: LGTM!

The changes in this code segment are consistent and correct:

• The account variable is correctly assigned the result of revokeLicensePlanFromAccount.
• The applyAuthorizationPolicy method is correctly called with the account variable.
• The method correctly returns the account variable.

---

168-175: LGTM!

The changes in this code segment are consistent and correct:

• The space variable is correctly assigned the result of revokeLicensePlanFromSpace.
• The applyAuthorizationPolicy method is correctly called with the space variable.
• The method correctly returns the space variable.

---

Line range hint 1-178: Overall, the changes in this file are consistent, correct, and adhere to best practices.

The code follows NestJS best practices, adheres to TypeScript's typing system, and is well-structured and modular. The changes involve renaming variables and updating the handling of license plans for accounts and spaces, which are implemented correctly.

Some additional observations and suggestions:

• The code handles errors and edge cases appropriately, such as checking for the existence of licensingID and falling back to the default licensing if not provided.
• The use of dependency injection and the @UseGuards decorator for authentication and authorization is a good practice.
• The code is well-documented with clear and concise comments explaining the purpose of each method and the need for triggering authorization resets.

Overall, the changes are ready to be merged.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Comoque1]

Tested OK locally:
assign:

revoke: