Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/DO-1610: address prematured completion of recache requests #1299

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Fix/DO-1610: address prematured completion of recache requests #1299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
982e755
DO-1610: remove looping as the queue message should have only one mes…
Jan 31, 2024
d6a8e71
DO-1610: roll back queue message handling
Feb 1, 2024
c06177a
DO-1610: replace forEach with classic for loop to avoid premaured fin…
Feb 1, 2024
38fdf0d
DO-1610: log SQS input entries
Feb 1, 2024
dc99ae6
DO-1610: simplify log data
Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/prerender-fargate/lib/recaching/prerender-recache-api-construct.api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,10 @@ const queueRecachineUrls = async (urlsToRecache: string[]) => {
Entries: urls.map(generateEntry),
});
});
console.log(`Queuing messages for SQS`, {
urlsToRecache: urlsToRecache[0],
messageEntries: messages[0].input.Entries,
});

console.log(`Sending ${messages.length} recaching message batches`);

Expand Down
11 changes: 7 additions & 4 deletions packages/prerender-fargate/lib/recaching/prerender-recache-api-construct.consumer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Context, SQSEvent, SQSRecord } from "aws-lambda";
import { Context, SQSEvent } from "aws-lambda";
import axios from "axios";

const userAgent = "prerender / Googlebot recaching request";
Expand All @@ -9,13 +9,16 @@ const userAgent = "prerender / Googlebot recaching request";
* @param context - The AWS Lambda context object.
*/
export const handler = async (event: SQSEvent, _context: Context) => {
event.Records.forEach(async (record: SQSRecord) => {
for (const record of event.Records) {
const url = record.body;
console.log(`Fetching ${url} for recaching`);
await axios.get(url, {
const res = await axios.get(url, {
headers: {
"User-Agent": userAgent,
},
});
});
console.log(
`Fetched URL: ${url}, Response Code: ${JSON.stringify(res.status)}`
);
}
};
Loading