Fix/DO-1610: address prematured completion of recache requests #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 31, 2024 16:15
TheOrangePuff
requested changes
Feb 2, 2024
| }); | ||
| console.log( | ||
| `Response data: ${JSON.stringify( | ||
| res.data |
There was a problem hiding this comment.
Logging the entire response data is going to produce some pretty big logs. Same with headers. I don't think we need that all the time. Can we just log the status code and the url fetched?
There was a problem hiding this comment.
Thanks. Yep, updated. We, however, may want to have a debugging flag in an update later.
TheOrangePuff
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
forinstead offorEachin order to ensure each of the URLs are requested before the lambda funtion completes its executionScreenshots (if applicable)
Other solutions considered (if any)
Notes to PR author
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback