-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bot name in help handler #89
base: master
Are you sure you want to change the base?
Changes from 2 commits
939f2f3
66d479f
2f04dca
150cc65
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ defmodule Alice.Handlers.HelpTest do | |
alias Alice.Handlers.TestHandler | ||
|
||
test "help_for_handler generates the correct output" do | ||
assert Help.help_for_handler(TestHandler) == | ||
assert Help.help_for_handler(TestHandler, %{slack: %{me: %{name: "alice"}}}) == | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adamzaninovich not a fan of this hard-coded conn. wasn't sure if there was a cleaner way to do this in tests? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe just use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yea I like, that at least hides the use of the |
||
""" | ||
>*Alice.Handlers.TestHandler* | ||
> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer this format (like the other functions in here):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 fixed