Use bot name in help handler #89
Conversation
test/alice/handlers/help_test.exs
Outdated
| @@ -4,7 +4,7 @@ defmodule Alice.Handlers.HelpTest do | |||
| alias Alice.Handlers.TestHandler | |||
|
|
|||
| test "help_for_handler generates the correct output" do | |||
| assert Help.help_for_handler(TestHandler) == | |||
| assert Help.help_for_handler(TestHandler, %{slack: %{me: %{name: "alice"}}}) == | |||
There was a problem hiding this comment.
@adamzaninovich not a fan of this hard-coded conn. wasn't sure if there was a cleaner way to do this in tests?
There was a problem hiding this comment.
maybe just use Conn.new and pass in the slack component
There was a problem hiding this comment.
Yea I like, that at least hides the use of the slack key to the internals until that gets changed with the whole different backend stuff.
|
Re: |
lib/alice/conn.ex
Outdated
| @doc """ | ||
| Returns the name of the bot | ||
| """ | ||
| def bot_name(conn), do: conn.slack.me.name |
There was a problem hiding this comment.
prefer this format (like the other functions in here):
def bot_name(conn = %Conn{}) do
conn.slack.me.name
end
test/alice/handlers/help_test.exs
Outdated
| @@ -4,7 +4,7 @@ defmodule Alice.Handlers.HelpTest do | |||
| alias Alice.Handlers.TestHandler | |||
|
|
|||
| test "help_for_handler generates the correct output" do | |||
| assert Help.help_for_handler(TestHandler) == | |||
| assert Help.help_for_handler(TestHandler, %{slack: %{me: %{name: "alice"}}}) == | |||
There was a problem hiding this comment.
maybe just use Conn.new and pass in the slack component
| assert Help.help_for_handler(TestHandler, conn) == test_help_message_output(conn) | ||
| end | ||
|
|
||
| defp test_help_message_output(%Alice.Conn{slack: %{me: %{name: bot_name}}}) do |
There was a problem hiding this comment.
Hmm maybe this should just use the Conn.bot_name on the passed in Conn, instead of deconstructing using the slack key again?
|
|
Currently when using the
helphandler it has the bot name hard coded to@alice. If you don't name your bot alice then the help context doesn't make sense.This PR adds
bot_name/1that takes theconnand will returns the bot's slack name.