fix service list can not search by groupName only #4302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update version to 1.3.0
Upgrade to 1.3.1 version
Upgrade to 1.3.2
Master upgrade 1.4.0
binbin0325
reviewed
Nov 22, 2020
| @@ -73,4 +73,9 @@ public static void checkServiceNameFormat(String combineServiceName) { | |||
| "Param 'serviceName' is illegal, it should be format as 'groupName@@serviceName'"); | |||
| } | |||
| } | |||
|
|
|||
| public static String getGroupedNameOptional(final String serviceName, final String groupName) { | |||
There was a problem hiding this comment.
You can add some comments
KomachiSion
requested changes
Nov 23, 2020
| * nil | groupA | threw IllegalArgumentException | ||
| * | ||
| * | ||
| * @return 'serviceName@@groupName' |
There was a problem hiding this comment.
serviceName@@groupName ? should groupName@@serviceName I think
| * See {@link com.alibaba.nacos.api.naming.utils.NamingUtils#getGroupedNameOptional(String, String)} | ||
| * | ||
| * etc: serviceName | groupName | result | ||
| * serviceA | groupA | serviceA@@groupA |
There was a problem hiding this comment.
Sorry, i have fix it.
| * nil | groupA | @@groupA | ||
| * nil | nil | @@ | ||
| * | ||
| * @return 'serviceName@@groupName' |
There was a problem hiding this comment.
same problem with above
|
Execute me, Your commit log has error. I think you need to fix it By rebase or checkout a new branch to modify and submit PR again. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4282