Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix service list can not search by groupName only #4302

Closed
wants to merge 10 commits into from
Closed

fix service list can not search by groupName only #4302

wants to merge 10 commits into from

Conversation

mark4z
Copy link
Contributor

@mark4z mark4z commented Nov 21, 2020

Fixes #4282

@mark4z mark4z closed this Nov 21, 2020
@mark4z mark4z reopened this Nov 21, 2020
@@ -73,4 +73,9 @@ public static void checkServiceNameFormat(String combineServiceName) {
"Param 'serviceName' is illegal, it should be format as 'groupName@@serviceName'");
}
}

public static String getGroupedNameOptional(final String serviceName, final String groupName) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add some comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,fine

* nil | groupA | threw IllegalArgumentException
*
*
* @return 'serviceName@@groupName'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serviceName@@groupName ? should groupName@@serviceName I think

* See {@link com.alibaba.nacos.api.naming.utils.NamingUtils#getGroupedNameOptional(String, String)}
*
* etc: serviceName | groupName | result
* serviceA | groupA | serviceA@@groupA
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serviceA@@groupa --》 groupA@@servicea

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i have fix it.

* nil | groupA | @@groupA
* nil | nil | @@
*
* @return 'serviceName@@groupName'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same problem with above

@KomachiSion
Copy link
Collaborator

Execute me, Your commit log has error. I think you need to fix it By rebase or checkout a new branch to modify and submit PR again.

@KomachiSion
Copy link
Collaborator

image

@mark4z mark4z closed this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.4.0 Service list Cannot query by group name
4 participants