Upgrade to 1.3.2 #3519

KomachiSion · 2020-08-04T10:08:28Z

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Upgrade to 1.3.2

This version refactors http client used in nacos-client, and rollback to use JDK http client to reduce the version conflict and enhance the log.
What's more, this version refactors eventDispatcher to improve the performance and readability.
Finally, fix some bugs and do some enhancement for console.

Brief changelog

[#1839] Add ContentType return while getConfig.
[#2856] Adjust the use of thread pools.
[#2858] Unified http client implementation, enhanced async request callback interface.
[#3091] Fix address server can't start up by implement an empty auth manager.
[#3103] Fix can't create properties config
[#3179] Replace the original Notify implementation in the nacos's other modules.
[#3197] NacosRestTemplate enhance.
[#3210] Enhanced nacos resttemplate response handler.
[#3224] nacos-client module http client replace.
[#3300] Optimize the default "minIdle"" of HikariPool set by naocs.
[#3311] Add specified Logger when constructing nacos resttemplate.
[#3317] Change the http client implementation that nacos resttemplate depends on from apache to JDk.
[#3324] Fix http client close bug.
[#3353] Adjust the value logic of clientBeatInterval.
[#3356] Fix no throw exception when publish event but no subsciber.
[#3366] Fix the thread safety problem of obtaining HttpRequestBase through BaseHttpMethod enumeration.
[#3370] Issue with executing shell script /bin/sh^M on Unix/Linux.
[#3382] Use PreparedStatement to replace string concatenation.
[#3388] Reset nacos roles, permissions during reloading role info from database.
[#3399] Unified implementation of http client package division.
[#3409] Fix Nacos can't start by the startup.cmd script in windows environment.
[#3428] Fix token valid go login bug.
[#3434] Fix DataAccessException when running in embedded mode.
[#3485] Fix the UnknownHostException is swallowed.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

…cs (#3304)

…and test module.

[ISSUE#3179]Replace the NotifyCenter with new refactor in the config and test module.

update `asInt()` to `asLong()`

* Enhanced nacos resttemplate response handler * Enhanced nacos resttemplate response handler * Add license * [#3212] Modify some class name and comment * [#3212] Modify some class name and comment * [#3212] Modify some class name and comment * [#3212] change the name of property * Fix code style issue

* enhance nacosRestTemplate * enhance nacosRestTemplate * supplement throw exception * Modify the iterate method of the interceptor and modify some method name * Adjust the way to get HttpClientRequest implement in NacosRestTempalte * Fix code style issue * Fix code style issue * Fix code style issue * Fix code style issue * Log output change

…d test module. (#3309) * [ISSUE#3179]Replace the NotifyCenter with new refactor in the core and test module. * [ISSUE#3179]Replace package in the nacos-logback.xml. * [ISSUE#3179]code reformat.

…3310)

* [ISSUE #2856]Adjust the use of thread pools (config、cmdb module) * add CmdbExecutor class

…3312)

…le. (#3313) * [ISSUE##2859]Replace some usage of EventDispatcher for ConfigCacheService and LongPollingService. * [ISSUE##2859]Replace some usage of EventDispatcher for AsyncNotifyService and ConfigChangePublisher. * [ISSUE#3179]fix typo. * [ISSUE#3179]fix typo. * [ISSUE#3179]fix typo.

…plate depends on from apache to JDk (#3322) * fix:#3317 change the http client implementation that nacos resttemplate depends on from apache to JDk * Use the IoUtils.closeQuietly() method to close the InputStream * change HttpClientBeanHolder logger output object

…3319)

…3333)

…r. (#3363)

…r. (#3364)

* nacos-client module http client replace * fix code style problem * add HashMap initialCapacity * fix code style problem * Modify the header object, keep the original response header to avoid modifying the original logic code * fix code style problem * naming http client request exception messages output change * Merge code

…ux (#3371) * Replace RuntimeException caused by HealthCheckerFactory with Nacos serialization exception * 1. Format startup.sh and shutdown.sh. Use Unix/Linux standard newline LF 2. Solve the OS = Windows error when packaging Maven (does not affect packaging)

…s enviroment. (#3416)

… database (#3442) * Reset nacos roles, permissions during reloading role info from database * Add volatile to guarantee visibility in threads

* Update issue templates * Delete duplicate bug report

…est callback interface (#3452) * Enhanced callback interface for asynchronous requests * change class name * add license * change class name * comment change * delete AbstractCallback

)

Fix checkstyle error (#3467)

…auth manager. (#3456) * Fix #3091 by empty auth manager. * Fix #3091 by empty auth manager. * Use conditional to solve bean conflict

* Fix browser Uncaught TypeError when create a Properties type configuration * Change Properties content verification method * Update front end resources

* 配置pageSize列表 #3439 * Service List Page Increase the number of pages switching function is the same as the configuration management page #3500

Alarcon1234 · 2022-09-04T17:27:42Z

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Upgrade to 1.3.2

This version refactors http client used in nacos-client, and rollback to use JDK http client to reduce the version conflict and enhance the log. What's more, this version refactors eventDispatcher to improve the performance and readability. Finally, fix some bugs and do some enhancement for console.

Brief changelog

[#1839] Add ContentType return while getConfig. [#2856] Adjust the use of thread pools. [#2858] Unified http client implementation, enhanced async request callback interface. [#3091] Fix address server can't start up by implement an empty auth manager. [#3103] Fix can't create properties config [#3179] Replace the original Notify implementation in the nacos's other modules. [#3197] NacosRestTemplate enhance. [#3210] Enhanced nacos resttemplate response handler. [#3224] nacos-client module http client replace. [#3300] Optimize the default "minIdle"" of HikariPool set by naocs. [#3311] Add specified Logger when constructing nacos resttemplate. [#3317] Change the http client implementation that nacos resttemplate depends on from apache to JDk. [#3324] Fix http client close bug. [#3353] Adjust the value logic of clientBeatInterval. [#3356] Fix no throw exception when publish event but no subsciber. [#3366] Fix the thread safety problem of obtaining HttpRequestBase through BaseHttpMethod enumeration. [#3370] Issue with executing shell script /bin/sh^M on Unix/Linux. [#3382] Use PreparedStatement to replace string concatenation. [#3388] Reset nacos roles, permissions during reloading role info from database. [#3399] Unified implementation of http client package division. [#3409] Fix Nacos can't start by the startup.cmd script in windows environment. [#3428] Fix token valid go login bug. [#3434] Fix DataAccessException when running in embedded mode. [#3485] Fix the UnknownHostException is swallowed.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.

Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.

Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.

Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

CsyDesign and others added 30 commits July 12, 2020 00:32

[ISSUE#3300] Optimize the default "minIdle"" of HikariPool set by nao…

84b733a

…cs (#3304)

[ISSUE#3179]Replace the NotifyCenter with new refactor in the config …

d8e1d2a

…and test module.

[ISSUE#3179]fix import formate issue.

34fd36b

Merge pull request #3305 from zongtanghu/feature_notifycenter_replace_v2

ee3b16b

[ISSUE#3179]Replace the NotifyCenter with new refactor in the config and test module.

Update BeatReactor.java (#3299)

eca82bf

update `asInt()` to `asLong()`

[ISSUE#3179]Replace the NotifyCenter with new refactor in the core an…

665d9d7

…d test module. (#3309) * [ISSUE#3179]Replace the NotifyCenter with new refactor in the core and test module. * [ISSUE#3179]Replace package in the nacos-logback.xml. * [ISSUE#3179]code reformat.

[ISSUE#3179]Remove original NotifyCenter codes in the core module. (#…

3a4e21b

…3310)

[ISSUE #2856]Adjust the use of thread pools (config module) (#3206)

891c1f3

* [ISSUE #2856]Adjust the use of thread pools (config、cmdb module) * add CmdbExecutor class

fix:#3311 Add specified Logger when constructing nacos resttemplate (#…

511ef88

…3312)

[ISSUE##2859]Remove original EventDispatcher in the config module. (#…

52d9cf9

…3319)

fix: #3324, Move http client close method to NamingProxy.shutdown() (#…

0163d2d

…3333)

[ISSUE#3356]fix no throw exception when publish event but no subscibe…

ff929b7

…r. (#3363)

[ISSUE#2859]fix no throw exception when publish event but no subscibe…

9f12f76

…r. (#3364)

Hotfix client sdk depend jdk7 charset. (#3374)

cda3f14

Hotfix client sdk depend jdk7 charset. (#3376)

e5f0c36

[#3353]Adjust the value logic of clientBeatInterval (#3377)

75dfd10

Use PrepareStatement to replace string concatenation (#3393)

2eaed4b

unified implementation of http client package division (#3400)

75a0683

[ISSUE#3409]fix Nacos can't start by the startup.cmd script in window…

479ef3f

…s enviroment. (#3416)

Fix bad SQL grammar (#3445)

c3818ff

Fix #3428, Fix token valid go login bug (#3449)

d19b441

[#3388]Reset nacos roles, permissions during reloading role info from…

377f778

… database (#3442) * Reset nacos roles, permissions during reloading role info from database * Add volatile to guarantee visibility in threads

Update issue templates (#3427)

bc3d13f

* Update issue templates * Delete duplicate bug report

[ISSUE #2858] Unified http client implementation, enhanced async requ…

5b76fd0

…est callback interface (#3452) * Enhanced callback interface for asynchronous requests * change class name * add license * change class name * comment change * delete AbstractCallback

Maijh97 and others added 9 commits July 29, 2020 13:10

fix get HttpRequestBase thread safe issues through BaseHttpMethod (#3469

e9152a9

)

[#1839]add ContentType return while getConfig

e4a478a

Fix checkstyle error (#3467)

1a22ae4

Fix checkstyle error (#3467)

[ISSUE#3091] Fix address server can't start up by implement an empty …

f377c19

…auth manager. (#3456) * Fix #3091 by empty auth manager. * Fix #3091 by empty auth manager. * Use conditional to solve bean conflict

[#1839]add ContentType return while getConfig (#3470)

43f6065

[ISSUE #3103] Fix can't create properties config (#3483)

4310b3e

* Fix browser Uncaught TypeError when create a Properties type configuration * Change Properties content verification method * Update front end resources

Fix the UnknownHostException is swallowed (#3495)

b79f048

[ISSUE #3439] Increment console config page size (#3507)

e4fdc38

* 配置pageSize列表 #3439 * Service List Page Increase the number of pages switching function is the same as the configuration management page #3500

Upgrade version to 1.3.2 (#3512)

df4b006

KomachiSion added this to the 1.3.2 milestone Aug 4, 2020

KomachiSion merged commit a341b65 into master Aug 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to 1.3.2 #3519

Upgrade to 1.3.2 #3519

KomachiSion commented Aug 4, 2020

Alarcon1234 commented Sep 4, 2022

What is the purpose of the change

Brief changelog

Verifying this change

Upgrade to 1.3.2 #3519

Upgrade to 1.3.2 #3519

Conversation

KomachiSion commented Aug 4, 2020

What is the purpose of the change

Brief changelog

Verifying this change

Alarcon1234 commented Sep 4, 2022

What is the purpose of the change

Brief changelog

Verifying this change