Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 1.3.2 #3519

Merged
merged 39 commits into from
Aug 4, 2020
Merged

Upgrade to 1.3.2 #3519

merged 39 commits into from
Aug 4, 2020

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Upgrade to 1.3.2

This version refactors http client used in nacos-client, and rollback to use JDK http client to reduce the version conflict and enhance the log.
What's more, this version refactors eventDispatcher to improve the performance and readability.
Finally, fix some bugs and do some enhancement for console.

Brief changelog

[#1839] Add ContentType return while getConfig.
[#2856] Adjust the use of thread pools.
[#2858] Unified http client implementation, enhanced async request callback interface.
[#3091] Fix address server can't start up by implement an empty auth manager.
[#3103] Fix can't create properties config
[#3179] Replace the original Notify implementation in the nacos's other modules.
[#3197] NacosRestTemplate enhance.
[#3210] Enhanced nacos resttemplate response handler.
[#3224] nacos-client module http client replace.
[#3300] Optimize the default "minIdle"" of HikariPool set by naocs.
[#3311] Add specified Logger when constructing nacos resttemplate.
[#3317] Change the http client implementation that nacos resttemplate depends on from apache to JDk.
[#3324] Fix http client close bug.
[#3353] Adjust the value logic of clientBeatInterval.
[#3356] Fix no throw exception when publish event but no subsciber.
[#3366] Fix the thread safety problem of obtaining HttpRequestBase through BaseHttpMethod enumeration.
[#3370] Issue with executing shell script /bin/sh^M on Unix/Linux.
[#3382] Use PreparedStatement to replace string concatenation.
[#3388] Reset nacos roles, permissions during reloading role info from database.
[#3399] Unified implementation of http client package division.
[#3409] Fix Nacos can't start by the startup.cmd script in windows environment.
[#3428] Fix token valid go login bug.
[#3434] Fix DataAccessException when running in embedded mode.
[#3485] Fix the UnknownHostException is swallowed.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

CsyDesign and others added 30 commits July 12, 2020 00:32
[ISSUE#3179]Replace the NotifyCenter with new refactor in the config and test module.
update `asInt()` to `asLong()`
* Enhanced nacos resttemplate response handler

* Enhanced nacos resttemplate response handler

* Add license

* [#3212] Modify some class name and comment

* [#3212] Modify some class name and comment

* [#3212] Modify some class name and comment

* [#3212] change the name of property

* Fix code style issue
* enhance nacosRestTemplate

* enhance nacosRestTemplate

* supplement throw exception

* Modify the iterate method of the interceptor and modify some method name

* Adjust the way to get HttpClientRequest implement in NacosRestTempalte

* Fix code style issue

* Fix code style issue

* Fix code style issue

* Fix code style issue

* Log output change
…d test module. (#3309)

* [ISSUE#3179]Replace the NotifyCenter with new refactor in the core and test module.

* [ISSUE#3179]Replace package in the nacos-logback.xml.

* [ISSUE#3179]code reformat.
* [ISSUE #2856]Adjust the use of thread pools (config、cmdb module)

* add CmdbExecutor class
…le. (#3313)

* [ISSUE##2859]Replace some usage of EventDispatcher for ConfigCacheService and LongPollingService.

* [ISSUE##2859]Replace some usage of EventDispatcher for AsyncNotifyService and ConfigChangePublisher.

* [ISSUE#3179]fix typo.

* [ISSUE#3179]fix typo.

* [ISSUE#3179]fix typo.
…plate depends on from apache to JDk (#3322)

* fix:#3317 change the http client implementation that nacos resttemplate depends on from apache to JDk

* Use the IoUtils.closeQuietly() method to close the InputStream

* change HttpClientBeanHolder logger output object
* nacos-client module http client replace

* fix code style problem

* add HashMap initialCapacity

* fix code style problem

* Modify the header object, keep the original response header to avoid modifying the original logic code

* fix code style problem

* naming http client request exception messages output change

* Merge code
…ux (#3371)

* Replace RuntimeException caused by HealthCheckerFactory with Nacos serialization exception

* 1. Format startup.sh and shutdown.sh. Use Unix/Linux standard newline LF
2. Solve the OS = Windows error when packaging Maven (does not affect packaging)
… database (#3442)

* Reset nacos roles, permissions during reloading role info from database

* Add volatile to guarantee visibility in threads
* Update issue templates

* Delete duplicate bug report
…est callback interface (#3452)

* Enhanced callback interface for asynchronous requests

* change class name

* add license

* change class name

* comment change

* delete AbstractCallback
Maijh97 and others added 9 commits July 29, 2020 13:10
Fix checkstyle error (#3467)
…auth manager. (#3456)

* Fix #3091 by empty auth manager.

* Fix #3091 by empty auth manager.

* Use conditional to solve bean conflict
* Fix browser Uncaught TypeError when create a Properties type configuration

* Change Properties content verification method

* Update front end resources
* 配置pageSize列表 #3439

* Service List Page Increase the number of pages switching function is the same as the configuration management page #3500
@KomachiSion KomachiSion added this to the 1.3.2 milestone Aug 4, 2020
@KomachiSion KomachiSion merged commit a341b65 into master Aug 4, 2020
@Alarcon1234
Copy link

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Upgrade to 1.3.2

This version refactors http client used in nacos-client, and rollback to use JDK http client to reduce the version conflict and enhance the log. What's more, this version refactors eventDispatcher to improve the performance and readability. Finally, fix some bugs and do some enhancement for console.

Brief changelog

[#1839] Add ContentType return while getConfig. [#2856] Adjust the use of thread pools. [#2858] Unified http client implementation, enhanced async request callback interface. [#3091] Fix address server can't start up by implement an empty auth manager. [#3103] Fix can't create properties config [#3179] Replace the original Notify implementation in the nacos's other modules. [#3197] NacosRestTemplate enhance. [#3210] Enhanced nacos resttemplate response handler. [#3224] nacos-client module http client replace. [#3300] Optimize the default "minIdle"" of HikariPool set by naocs. [#3311] Add specified Logger when constructing nacos resttemplate. [#3317] Change the http client implementation that nacos resttemplate depends on from apache to JDk. [#3324] Fix http client close bug. [#3353] Adjust the value logic of clientBeatInterval. [#3356] Fix no throw exception when publish event but no subsciber. [#3366] Fix the thread safety problem of obtaining HttpRequestBase through BaseHttpMethod enumeration. [#3370] Issue with executing shell script /bin/sh^M on Unix/Linux. [#3382] Use PreparedStatement to replace string concatenation. [#3388] Reset nacos roles, permissions during reloading role info from database. [#3399] Unified implementation of http client package division. [#3409] Fix Nacos can't start by the startup.cmd script in windows environment. [#3428] Fix token valid go login bug. [#3434] Fix DataAccessException when running in embedded mode. [#3485] Fix the UnknownHostException is swallowed.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.