Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the use of thread pools #2856

Closed
chuntaojun opened this issue May 22, 2020 · 1 comment
Closed

Adjust the use of thread pools #2856

chuntaojun opened this issue May 22, 2020 · 1 comment
Assignees
@wangweizZZ
Labels
contribution welcome
Milestone
1.3.2

Comments

@chuntaojun
Copy link
Collaborator

Issue Description

Type: feature request

Describe what happened (or what feature you want)

background

  1. The use of thread pool only applies regardless of closing
  2. Need to collect and manage the life cycle of the thread pool
    Ideas
  3. The executor in the nacos-common package is a unified thread pool package, and unified life cycle management will be incorporated during the creation process
  4. Unifiedly adjust the current existing way of creating thread pools in Nacos to the way of ExecutorFactory.xxx

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?
@chuntaojun chuntaojun added this to the 1.3.0 milestone May 22, 2020
@wangweizZZ
Copy link
Collaborator

@i will solve it@

@KomachiSion KomachiSion modified the milestones: 1.3.0, 1.3.1 Jun 10, 2020
wangweizZZ added a commit to wangweizZZ/nacos that referenced this issue Jun 16, 2020
@wangweizZZ
[ISSUE alibaba#2856]Adjust the use of thread pools
06b1990
@wangweizZZ wangweizZZ mentioned this issue Jun 16, 2020
Merged
5 tasks
wangweizZZ added a commit to wangweizZZ/nacos that referenced this issue Jun 17, 2020
@wangweizZZ
[ISSUE alibaba#2856][module:core、consistency]Adjust the use of thread…
315cf81 
… pools

Change-Id: I793770ca0f287157dc88e3ecf1147ea308e4a547
chuntaojun pushed a commit that referenced this issue Jun 17, 2020
@wangweizZZ
[ISSUE #2856]Adjust the use of thread pools (#3084)
f94e8f8 
* [ISSUE #2856][module:core、consistency]Adjust the use of thread pools

Change-Id: I793770ca0f287157dc88e3ecf1147ea308e4a547

* code optimize

Change-Id: I023ed73332f3f69c93277f25e57e0ee5c3975f02
@wangweizZZ wangweizZZ mentioned this issue Jun 21, 2020
Merged
5 tasks
wangweizZZ added a commit to wangweizZZ/nacos that referenced this issue Jun 24, 2020
@wangweizZZ
[ISSUE alibaba#2856]Adjust the use of thread pools (naming module)
5b59201 
Change-Id: I626179bd9ee8e852d9d51787950ad80744ec71cd
KomachiSion pushed a commit that referenced this issue Jun 28, 2020
@wangweizZZ
[ISSUE #2856]Adjust the use of thread pools (naming module) (#3136)
3f145e6 
Change-Id: I626179bd9ee8e852d9d51787950ad80744ec71cd
@KomachiSion KomachiSion modified the milestones: 1.3.1, 1.3.2 Jun 28, 2020
@wangweizZZ wangweizZZ mentioned this issue Jun 30, 2020
Merged
5 tasks
wangweizZZ added a commit to wangweizZZ/nacos that referenced this issue Jul 11, 2020
@wangweizZZ
[ISSUE alibaba#2856]Adjust the use of thread pools (config、cmdb module)
94f6c61
KomachiSion pushed a commit that referenced this issue Jul 13, 2020
@wangweizZZ
[ISSUE #2856]Adjust the use of thread pools (config module) (#3206)
891c1f3 
* [ISSUE #2856]Adjust the use of thread pools (config、cmdb module)

* add CmdbExecutor class
@KomachiSion KomachiSion reopened this Jul 27, 2020
@KomachiSion KomachiSion mentioned this issue Aug 4, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangweizZZ wangweizZZ

Labels
contribution welcome
Projects
None yet
Milestone
1.3.2
Development

No branches or pull requests
3 participants
@wangweizZZ @chuntaojun @KomachiSion