Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming model refactor #300

Merged
merged 51 commits into from
Nov 16, 2018
Merged

Naming model refactor #300

merged 51 commits into from
Nov 16, 2018

Conversation

nkorange
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Refactor naming module and bug fix.

Brief changelog

  1. [ISSUE naming的日志级别 #241 ] Update log level.
  2. [ISSUE Disable service and cluster level customization in client registerInstance method #209, Naming client registering instance method should be differentiated from registering service method #195 ] Client edit service and cluster disabled.
  3. [ISSUE NPE when adding a instance if no leader in the raft cluster  #181 ] Fix NPE of naming module.
  4. [ISSUE Console supports registering new empty service and delete empty service #177 ] Console support creating and deleting service.
  5. [ISSUE Naming client query instance method should bypass local cache at client start. #176 ] Client visit server to get data at client start.
  6. [ISSUE Support deregistering instance automatically #175 ] Remove instance automatically, also known as TTL.
  7. [ISSUE Naming write performace #148 ] Improve naming write performance.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

nkorange and others added 30 commits October 29, 2018 20:34
# Conflicts:
#	api/pom.xml
#	client/pom.xml
#	common/pom.xml
#	config/pom.xml
#	console/pom.xml
#	core/pom.xml
#	distribution/pom.xml
#	example/pom.xml
#	naming/pom.xml
#	pom.xml
#	test/pom.xml
change to the latest release version 0.4.0
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 9 committers have signed the CLA.

✅ jun1st
✅ yangyshdan
✅ xuechaos
✅ hxy1991
✅ wfnuser
✅ jameslcj
❌ nkorange
❌ pguo
❌ pguo65535


pguo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nkorange nkorange merged commit 57f2ae4 into develop Nov 16, 2018
@KomachiSion KomachiSion deleted the naming-model-refactor branch June 17, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.