Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #251 ]Console Editor Optimization #264

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

wfnuser
Copy link
Collaborator

@wfnuser wfnuser commented Nov 12, 2018

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Optimize the user experience of the console editor.

Brief changelog

[ISSUE #251 ]

  1. disable the folding feature of editor to remove the unexpected padding of editor.

Remove the Balloon of DataId/Group

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@jameslcj jameslcj merged commit a7dc3c6 into alibaba:master Nov 12, 2018
@wfnuser wfnuser deleted the fix/console_editor_optimization branch November 13, 2018 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants