Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #10824] Remove udp port param for v1-client #10914

Merged
merged 6 commits into from
Aug 4, 2023

Conversation

ZhangShenao
Copy link
Contributor

@ZhangShenao ZhangShenao commented Aug 4, 2023

Remove udp port param for v1-client

#10824

@ZhangShenao ZhangShenao changed the title Remove udp param for v1-client [ISSUE 10824] Remove udp port param for v1-client Aug 4, 2023
@ZhangShenao ZhangShenao changed the title [ISSUE 10824] Remove udp port param for v1-client [ISSUE #10824] Remove udp port param for v1-client Aug 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #10914 (6ff5798) into develop (de87bb3) will decrease coverage by 0.11%.
The diff coverage is 88.23%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10914      +/-   ##
=============================================
- Coverage      53.30%   53.19%   -0.11%     
  Complexity      5628     5628              
=============================================
  Files            927      927              
  Lines          29568    29551      -17     
  Branches        3250     3249       -1     
=============================================
- Hits           15760    15720      -40     
- Misses         12437    12461      +24     
+ Partials        1371     1370       -1     
Files Changed Coverage Δ
...ient/naming/remote/gprc/NamingGrpcClientProxy.java 92.46% <0.00%> (+0.57%) ⬆️
...s/client/naming/core/ServiceInfoUpdateService.java 46.23% <66.66%> (ø)
...libaba/nacos/client/naming/NacosNamingService.java 90.66% <100.00%> (-0.07%) ⬇️
...lient/naming/remote/NamingClientProxyDelegate.java 85.29% <100.00%> (-0.43%) ⬇️
...ient/naming/remote/http/NamingHttpClientProxy.java 81.72% <100.00%> (-0.10%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de87bb3...6ff5798. Read the comment docs.

@KomachiSion KomachiSion merged commit 3fdcb5c into alibaba:develop Aug 4, 2023
6 checks passed
@ZhangShenao
Copy link
Contributor Author

@ready to close@

realJackSun added a commit that referenced this pull request Aug 10, 2023
…lop branch (#10942)

* [ISSUE #10734] Implement http request param check filter and http param extractors (#10758)

* For #10734,Implement grpc server interceptor and grpc param extractors

* For #10734,add unit test for grpc server interceptor and grpc param extractors

* For #10734,alter the test case

* For #10734,delete the ConnectionSetupRequestParamExtractor

* For #10734,add the naming http request param check filter and implement the naming http request param extractors

* For #10734,add unit test for naming http request param extractors

* For #10734,Implement grpc server interceptor and grpc param extractors

* For #10734,add unit test for grpc server interceptor and grpc param extractors

* For #10734,delete the ConnectionSetupRequestParamExtractor

* For #10734,add the naming http request param check filter and implement the naming http request param extractors

* For #10734,add unit test for naming http request param extractors

* For #10734,add the config http request param check filter and implement the config http request param extractors and unit test

* For #10734,add the console http request param check filter and implement the console http request param extractors and unit test

* For #10734,fix code style

* For #10734,alter the logic of exception handle in filter

* For #10734,fix code style

* dump change check task submit (#10755)

* dump change check task submit

* delete config nid convert error fix

* fix test case

* checkstyle

* Refactor grpc tls (#10759)

* Move Tls negotiator to GrpcSdkServer.

* use protocol negotiator builder replace directly create.

* use SPI load negotiator and set tls as default negotiator.

* Remove tlsconfig in BaseRpcServer.

* Add some ut.

* For checkstyle.

* fix word spelling in `AuthenticationManagerDelegator` (#10777)

* fix(#10427): When the execution of handleServerRequest() encounters an exception, record the log and throw an exception, then quickly response to the server errResponse (#10770)

* fix(#10585): selectInstances and selectOneHealthyInstance methods, if the parameter subscribe is true. Subscription is required when clientProxy.isSubscribe() is false. (#10805)

* disable check port input when use registered port (#10799)

* Add the handle to overload connection (#10783)

* add the handle to overload connection

* fast return

* [ISSUE #10662]Prometheus-sd add namespace and service api (#10663)

* add apis

* add tests

* fix checkstyle

* param namespace to namespaceId

* namespace to namespaceId

* fix test case

* fix test case

* Service instance should display related color when healthy or unhealthy (#10811)

* fix a couple of invaild props (#10810)

* feat(#10539): When the operation configuration fails, log. (#10804)

* [ISSUE #10744]feat:Add HealthControllerV2 and HealthControllerV2Test (#10786)

* [ISSUE #10744]feat:Add HealthControllerV2 and HealthControllerV2Test

* fix:V2 api return Result

* [ISSUE #10734] Refactor the ParamChecker and ParamExtractor (#10775)

* For #10734,refactor the paramextractor and ParamChecker

* For #10734,alter the rules of ParamCheck

* For #10734,alter the rules of ParamCheck

* For #10734,fix bug

* For #10734,fix bug and alter the ParamCheckRules.java

* For #10734,fix code style

* For #10734,fix the param check rules

* For #10734,implement the server param check config

* For #10734,optimize the logic

* For #10734,optimize the logic

* For #10734,optimize the logic

* Refactor Prometheus Module (#10827)

* Refactor Prometheus Module

* Complete Test Case

* format

* format

* For #10734,fix the param check rule (#10826)

* [ISSUE #10792]When nacos client use endpoint, the registration center should support configuring context-path and cluster-name like the configuration center (#10793)

* Reactor code in datasource-plugin (#10791)

* Reactor code in datasource-plugin

* Fix Abstract Mapper Test Case

* Add Empty Check

* Fix Checkstyle

* fix checkstyle

* fix check style

* fix check style

* Fix CheckStyle

* Fix SQL Blank

* bugfix for PersistentClientOperationServiceImpl log (#10825)

* For #10734,fix the param check rule (#10858)

* fix(#10831): When using the deregisterInstance method to remove one of multiple instances registered by batchRegisterInstance, all instances registered by batchRegisterInstance will be removed. (#10836)

* UnsupportedFeatureError (#10860)

* fix(distro): fix issue#10880. (#10881)

* feat(#5608 && #10223): When the custom instance id is empty, the id will be automatically generated. (#10812)

* fix: test-code branch (#10904)

* add nacos ci

* delete client version of nacos ci

* fix: test-code branch

* console-ui 新增 toml 语言支持,修复之前 properties 主题未生效的问题 (#10896)

* console-ui 新增 toml 语言支持,修复之前 properties 主题未生效的问题

* console-ui 新增 toml 语言支持,修复之前 properties 主题未生效的问题

* 老规矩,要编译一波

* feat(10891): Provide a configuration item for the maximum number of push retries, instead of directly hardcoding it to 50 times in the code. (#10895)

* [ISSUE #10824] Remove udp port param for v1-client (#10914)

* Remove UDP Param

* Fix gRPC client

* fix test case

* fix test case

* fix test case

* fix test case

* Fix login failed when close auth.

---------

Co-authored-by: Sunrisea <[email protected]>
Co-authored-by: nov.lzf <[email protected]>
Co-authored-by: 杨翊 SionYang <[email protected]>
Co-authored-by: ZhangShenao <[email protected]>
Co-authored-by: blake.qiu <[email protected]>
Co-authored-by: Joey777210 <[email protected]>
Co-authored-by: chenyiqin <[email protected]>
Co-authored-by: maoling <[email protected]>
Co-authored-by: DiligenceLai <[email protected]>
Co-authored-by: huhongjie2014 <[email protected]>
Co-authored-by: lu-xiaoshuang <[email protected]>
Co-authored-by: zt9788 <[email protected]>
Co-authored-by: 阿魁 <[email protected]>
Co-authored-by: wuyfee <[email protected]>
Co-authored-by: Darren Luo <[email protected]>
Co-authored-by: xxc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants