feat(#5608 && #10223): When the custom instance id is empty, the id will be automatically generated.

[Bo-Qiu]

What is the purpose of the change

feat(#5608 && #10223): When the custom instance id is empty, the id will be automatically generated.

[Bo-Qiu]

Based on our discussions, I re-wrote the code and submitted a new PR, please review it again, thx!
@KomachiSion

[codecov-commenter]

Codecov Report

Merging #10812 (63f1bd7) into develop (f986916) will decrease coverage by 0.12%.
Report is 13 commits behind head on develop.
The diff coverage is 83.33%.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #10812      +/-   ##
=============================================
- Coverage      53.44%   53.32%   -0.12%     
+ Complexity      5626     5625       -1     
=============================================
  Files            923      927       +4     
  Lines          29458    29567     +109     
  Branches        3244     3250       +6     
=============================================
+ Hits           15743    15768      +25     
- Misses         12339    12413      +74     
- Partials        1376     1386      +10     

Files Changed	Coverage Δ
...a/com/alibaba/nacos/naming/utils/InstanceUtil.java	73.46% <80.00%> (+1.67%)	⬆️
...emote/rpc/handler/BatchInstanceRequestHandler.java	100.00% <100.00%> (ø)
...ing/remote/rpc/handler/InstanceRequestHandler.java	100.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f986916...63f1bd7. Read the comment docs.

[KomachiSion]

Please use DefaultInstanceIdGenerator to generate default Id like http register

[KomachiSion]

com.alibaba.nacos.naming.pojo.instance.HttpRequestInstanceBuilder#setInstanceId

[Bo-Qiu]

Please use DefaultInstanceIdGenerator to generate default Id like http register

In fact, my implementation is consistent with it. could you provide more information? thanks a lot.

[Bo-Qiu]

Please use DefaultInstanceIdGenerator to generate default Id like http register

Is your suggestion to directly set the ID using it regardless of whether the customID is empty or not? Code as follow:

private void setInstanceId(Instance instance) {
        DefaultInstanceIdGenerator idGenerator = new DefaultInstanceIdGenerator(instance.getServiceName(),
                instance.getClusterName(), instance.getIp(), instance.getPort());
        instance.setInstanceId(idGenerator.generateInstanceId());
    }

I think there are some problems with using it directly. In GRPC mode, the filed serviceName of instance could be empty when registering an instance. During the process of registering an instance via Grpc, we are directly using the value of the service's name field.

By the way, whether it's necessary to maintain the logic of custom instance IDs is also a topic worth discussing.

[KomachiSion]

You can see com.alibaba.nacos.naming.pojo.instance.HttpRequestInstanceBuilder#setAttributesToBuilder

the instance service name in from the request.
so grpc also should use service name in request.

service name in request should not be null acutally.

[Bo-Qiu]

Thanks for your information, I've changed it.

[KomachiSion]

Is this will lose the group name?

[Bo-Qiu]

Thank you for your reminder, I have already fixed this issue, please review it again.