-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #10734] Implement grpc server interceptor and grpc param extractors #10745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KomachiSion
approved these changes
Jul 10, 2023
KomachiSion
requested changes
Jul 10, 2023
...c/main/java/com/alibaba/nacos/core/paramcheck/impl/ConnectionSetupRequestParamExtractor.java
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #10745 +/- ##
=============================================
+ Coverage 53.60% 53.66% +0.05%
- Complexity 5565 5590 +25
=============================================
Files 904 912 +8
Lines 29054 29183 +129
Branches 3208 3219 +11
=============================================
+ Hits 15575 15661 +86
- Misses 12109 12145 +36
- Partials 1370 1377 +7
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
KomachiSion
approved these changes
Jul 10, 2023
lowezheng
added a commit
to lowezheng/nacos
that referenced
this pull request
Jul 11, 2023
* develop: Refactor grpc tls (alibaba#10759) dump change check task submit (alibaba#10755) [ISSUE alibaba#10734] Implement http request param check filter and http param extractors (alibaba#10758) nacos ui doc update to v2 (alibaba#10730) fix for react unique key warning (alibaba#10742) [ISSUE alibaba#10734] Implement grpc server interceptor and grpc param extractors (alibaba#10745) improvements for leave node api and UI (alibaba#10748) Delete client version (alibaba#10754)
wukong121
pushed a commit
to wukong121/nacos
that referenced
this pull request
Aug 4, 2023
…m extractors (alibaba#10745) * For alibaba#10734,Implement grpc server interceptor and grpc param extractors * For alibaba#10734,add unit test for grpc server interceptor and grpc param extractors * For alibaba#10734,alter the test case * For alibaba#10734,delete the ConnectionSetupRequestParamExtractor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Implement grpc server interceptor and grpc param extractors for issue #10734
Brief changelog
Implement grpc server interceptor and grpc param extractors.
Add unit test for grpc server interceptor and grpc param extractors.
Optimize the logic of RpcParamExtractorManager.
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.