Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #10734] Implement grpc server interceptor and grpc param extractors #10745

Merged
merged 4 commits into from
Jul 10, 2023
Merged

[ISSUE #10734] Implement grpc server interceptor and grpc param extractors #10745

merged 4 commits into from
Jul 10, 2023

Conversation

Sunrisea
Copy link
Contributor

@Sunrisea Sunrisea commented Jul 7, 2023

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Implement grpc server interceptor and grpc param extractors for issue #10734

Brief changelog

Implement grpc server interceptor and grpc param extractors.
Add unit test for grpc server interceptor and grpc param extractors.
Optimize the logic of RpcParamExtractorManager.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • [Y] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [Y] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [Y] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [Y] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [Y] Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #10745 (b1c5dc7) into develop (ba8e0e2) will increase coverage by 0.05%.
The diff coverage is 57.69%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10745      +/-   ##
=============================================
+ Coverage      53.60%   53.66%   +0.05%     
- Complexity      5565     5590      +25     
=============================================
  Files            904      912       +8     
  Lines          29054    29183     +129     
  Branches        3208     3219      +11     
=============================================
+ Hits           15575    15661      +86     
- Misses         12109    12145      +36     
- Partials        1370     1377       +7     
Impacted Files Coverage Δ
...acos/core/paramcheck/RpcParamExtractorManager.java 76.19% <0.00%> (+13.03%) ⬆️
...a/com/alibaba/nacos/core/remote/BaseRpcServer.java 80.00% <ø> (ø)
...e/remote/grpc/GrpcServerParamCheckInterceptor.java 5.26% <5.26%> (ø)
...k/impl/ConfigBatchListenRequestParamExtractor.java 40.00% <40.00%> (ø)
...check/impl/BatchInstanceRequestParamExtractor.java 50.00% <50.00%> (ø)
...paramcheck/impl/InstanceRequestParamExtractor.java 58.82% <58.82%> (ø)
...ck/impl/SubscribeServiceRequestParamExtractor.java 73.33% <73.33%> (ø)
...mcheck/impl/ServiceQueryRequestParamExtractor.java 75.00% <75.00%> (ø)
...e/paramcheck/impl/ConfigRequestParamExtractor.java 100.00% <100.00%> (ø)
...amcheck/impl/ServiceListRequestParamExtractor.java 100.00% <100.00%> (ø)
... and 1 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba8e0e2...b1c5dc7. Read the comment docs.

@KomachiSion KomachiSion merged commit cae21e2 into alibaba:develop Jul 10, 2023
@KomachiSion KomachiSion added the kind/feature type/feature label Jul 10, 2023
lowezheng added a commit to lowezheng/nacos that referenced this pull request Jul 11, 2023
* develop:
  Refactor grpc tls (alibaba#10759)
  dump change check task submit (alibaba#10755)
  [ISSUE alibaba#10734] Implement http request param check filter and http param extractors (alibaba#10758)
  nacos ui doc update to v2 (alibaba#10730)
  fix for react unique key warning (alibaba#10742)
  [ISSUE alibaba#10734] Implement grpc server interceptor and grpc param extractors (alibaba#10745)
  improvements for leave node api and UI (alibaba#10748)
  Delete client version (alibaba#10754)
wukong121 pushed a commit to wukong121/nacos that referenced this pull request Aug 4, 2023
…m extractors (alibaba#10745)

* For alibaba#10734,Implement grpc server interceptor and grpc param extractors

* For alibaba#10734,add unit test for grpc server interceptor and grpc param extractors

* For alibaba#10734,alter the test case

* For alibaba#10734,delete the ConnectionSetupRequestParamExtractor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants