Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nacos ui doc update to v2 #10730

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Conversation

Joey777210
Copy link
Contributor

@Joey777210 Joey777210 commented Jul 4, 2023

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

update nacos doc link, fix #10729

Brief changelog

change links in js files

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

KomachiSion
KomachiSion previously approved these changes Jul 5, 2023
@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Jul 5, 2023
@KomachiSion KomachiSion added this to the 2.3.0 milestone Jul 5, 2023
@KomachiSion
Copy link
Collaborator

Sorry, there is some one change console code so that conflicts. Can you solve it .

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.52%. Comparing base (a704835) to head (d9d8567).
Report is 446 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10730      +/-   ##
=============================================
- Coverage      53.66%   53.52%   -0.15%     
- Complexity      5520     5523       +3     
=============================================
  Files            897      897              
  Lines          28885    28885              
  Branches        3181     3181              
=============================================
- Hits           15502    15460      -42     
- Misses         12029    12065      +36     
- Partials        1354     1360       +6     

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a704835...d9d8567. Read the comment docs.

@wilsonwu
Copy link
Contributor

wilsonwu commented Jul 5, 2023

Seems the v2 documents still need to get more improvement
image

# Conflicts:
#	console/src/main/resources/static/index.html
#	console/src/main/resources/static/js/main.js
@Joey777210
Copy link
Contributor Author

I think there will be no conflict.

@KomachiSion KomachiSion merged commit 1f5dbf0 into alibaba:develop Jul 10, 2023
lowezheng added a commit to lowezheng/nacos that referenced this pull request Jul 11, 2023
* develop:
  Refactor grpc tls (alibaba#10759)
  dump change check task submit (alibaba#10755)
  [ISSUE alibaba#10734] Implement http request param check filter and http param extractors (alibaba#10758)
  nacos ui doc update to v2 (alibaba#10730)
  fix for react unique key warning (alibaba#10742)
  [ISSUE alibaba#10734] Implement grpc server interceptor and grpc param extractors (alibaba#10745)
  improvements for leave node api and UI (alibaba#10748)
  Delete client version (alibaba#10754)
wukong121 pushed a commit to wukong121/nacos that referenced this pull request Aug 4, 2023
* nacos ui doc update to v2

* nacos ui doc update to v2

* fix conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nacos UI document update to v2
4 participants