Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix degrade_service.js alert message issue 2476 #2483

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

Reagan1947
Copy link
Contributor

Commit Message

fix the degrade_service.js alert message on line 77, changed "统计窗口市场不能超过 120 分钟" to "统计窗口时长最大 120s"

Describe what this PR does / why we need it

Issue

错误的提示信息,degrade_service.js 提示:统计窗口市场不能超过 120 分钟,此处单位应当为 s(秒)

Change

"统计窗口市场不能超过 120 分钟" -> "统计窗口时长最大 120s"

Does this pull request fix one issue?

Fixes #2476

Describe how you did it

变更提示信息

Describe how to verify it

/

Special notes for reviews

/

fix the degrade_service.js alert message on line 77, changed "统计窗口市场不能超过 120 分钟" to "统计窗口时长最大 120s"
@sczyh30 sczyh30 added the area/dashboard Issues or PRs about Sentinel Dashboard label Dec 6, 2021
@sczyh30
Copy link
Member

sczyh30 commented Dec 6, 2021

cc @Tank-zhu

@Reagan1947
Copy link
Contributor Author

cc @Tank-zhu

还需要提供测试用例吗?如果 @@Tank-zhu 未回复,我可以跟进。

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 added this to the 1.8.4 milestone Jan 19, 2022
@sczyh30 sczyh30 merged commit 2920efc into alibaba:master Jan 19, 2022
@sczyh30
Copy link
Member

sczyh30 commented Jan 19, 2022

Thanks for contributing!

Zhang-0952 pushed a commit to Zhang-0952/Sentinel that referenced this pull request Mar 4, 2022
…ircuit breaker rule dialog (alibaba#2483)

* fix the degrade_service.js alert message on line 77, changed "统计窗口市场不能超过 120 分钟" to "统计窗口时长最大 120s"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

统计时长的限制与实际的警告信息不一致
2 participants