Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

统计时长的限制与实际的警告信息不一致 #2476

Closed
Tank-zhu opened this issue Dec 2, 2021 · 1 comment · Fixed by #2483
Closed

统计时长的限制与实际的警告信息不一致 #2476

Tank-zhu opened this issue Dec 2, 2021 · 1 comment · Fixed by #2483
Labels
area/dashboard Issues or PRs about Sentinel Dashboard good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.

Comments

@Tank-zhu
Copy link

Tank-zhu commented Dec 2, 2021

Issue Description

Type: bug report

Describe what happened (or what feature you want)

1638413761725_E8DC0D6C-0855-4C41-BFCA-B9D14B161A40
1638416567624_46BFA5E0-F1E9-4403-897A-BFB89C56C83D
1638416824877_4BBA1EC8-B858-49C9-AA5C-2F358424485D

此处判断应该是不能大于120秒，但提示信息为120分钟

请问应该是修改 alert的消息，还是修改判断的条件？
@sczyh30 sczyh30 added the area/dashboard Issues or PRs about Sentinel Dashboard label Dec 3, 2021
@sczyh30
Copy link
Member

sczyh30 commented Dec 3, 2021

这里的场景按照”最大120s“的语义一般足够，可以按照这个来进行统一，欢迎提交 PR

@sczyh30 sczyh30 added good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement. labels Dec 3, 2021
@Reagan1947 Reagan1947 mentioned this issue Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dashboard Issues or PRs about Sentinel Dashboard good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix degrade_service.js alert message issue 2476 Reagan1947/Sentinel
2 participants
@sczyh30 @Tank-zhu