Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX NPE when update ParamFlowRule before the resource has been requested once #1901

Merged
merged 1 commit into from
Dec 18, 2020
Merged

FIX NPE when update ParamFlowRule before the resource has been requested once #1901

merged 1 commit into from
Dec 18, 2020

Commits on Dec 15, 2020

  1. Describe what this PR does / why we need it 

    fix issue: alibaba#1895
Does this pull request fix one issue?
fix alibaba#1895
Describe how you did it
just add a judge to if the ParameterMetric is null
Describe how to verify it
run com.alibaba.csp.sentinel.slots.block.flow.param.ParamFlowRuleManagerTest#testLoadParamRulesWithNoMetric to check whether the new value is be set
Special notes for reviews
    @brotherlu-xcq
    brotherlu-xcq committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    c5ca6b0 View commit details
    Browse the repository at this point in the history