FIX NPE when update ParamFlowRule before the resource has been requested once #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issue: alibaba#1895 Does this pull request fix one issue? fix alibaba#1895 Describe how you did it just add a judge to if the ParameterMetric is null Describe how to verify it run com.alibaba.csp.sentinel.slots.block.flow.param.ParamFlowRuleManagerTest#testLoadParamRulesWithNoMetric to check whether the new value is be set Special notes for reviews
|
|
sczyh30
added
kind/bug
|
Thanks for contributing and look forward to more! |
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
… has been requested once (alibaba#1901)
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
…roker 4.7.0 fix(broker):fix bug sending request message using broker 4.7.0 (alibaba#1902)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
fix issue: #1895
Does this pull request fix one issue?
fix #1895
Describe how you did it
just add a judge to if the ParameterMetric is null before clear the ParamFlowRule
Describe how to verify it
run com.alibaba.csp.sentinel.slots.block.flow.param.ParamFlowRuleManagerTest#testLoadParamRulesWithNoMetric to check whether the new value is set
Special notes for reviews