[Fixes #1856] adjust decision logic when errRequestRatio equals 1.0 #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
added
the
area/circuit-breaking
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
|
|
|
|
xierunzi
force-pushed
the
feat/degrade_err_ratio
branch
3 times, most recently
from
132750d
to
aa9fcf8
Compare
xierunzi
force-pushed
the
feat/degrade_err_ratio
branch
from
aa9fcf8
to
99a2e64
Compare
|
A remaining PR requires review. Related to #1856 and #1769, and the pre PR is #1779 @sczyh30 @brotherlu-xcq |
|
cc @alibaba/sentinel-committer @LearningGp @chenzhiguo for review. This should be included in 2.0 milestone. |
|
Will version 1.8.x not consider fixing this issue? |
chenzhiguo
reviewed
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when ratio == 1, requests will never be blocked. Fixed the judgment logic in this case.
Fixes #1856