Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When errRatioThreshold equals 1.0，requests will never be blocked #1856

Open
xierunzi opened this issue Nov 15, 2020 · 0 comments · May be fixed by #1857
Open

When errRatioThreshold equals 1.0，requests will never be blocked #1856

xierunzi opened this issue Nov 15, 2020 · 0 comments · May be fixed by #1857
Labels
area/circuit-breaking Issues or PRs related to circuit breaking kind/bug Category issues or prs related to bug.

Comments

@xierunzi
Copy link
Contributor

异常比例阈值为1时，当前判断逻辑无法触发降级，正确判断逻辑应该是当比例阈值为1时，等于即可触发降级。
@xierunzi xierunzi linked a pull request Nov 15, 2020 that will close this issue
Open
@sczyh30 sczyh30 added the area/circuit-breaking Issues or PRs related to circuit breaking label Nov 16, 2020
xierunzi added a commit to xierunzi/Sentinel that referenced this issue Jul 17, 2022
@xierunzi
Fix the problem that requests will never be blocked when errRatioThre…
132750d 
…shold = 100%(alibaba#1856)
xierunzi added a commit to xierunzi/Sentinel that referenced this issue Jul 17, 2022
@xierunzi
Fix the problem that requests will never be blocked when errRatioThre…
c9b7af7 
…shold = 100%(alibaba#1856)
xierunzi added a commit to xierunzi/Sentinel that referenced this issue Jul 17, 2022
@xierunzi
Fix the problem that requests will never be blocked when errRatioThre…
aa9fcf8 
…shold = 100%(alibaba#1856)
xierunzi added a commit to xierunzi/Sentinel that referenced this issue Jul 17, 2022
@xierunzi
Fix the problem that requests will never be blocked when errRatioThre…
99a2e64 
…shold = 100%(alibaba#1856)
@sczyh30 sczyh30 added the kind/bug Category issues or prs related to bug. label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/circuit-breaking Issues or PRs related to circuit breaking kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fixes #1856] adjust decision logic when errRequestRatio equals 1.0 xierunzi/Sentinel
2 participants
@sczyh30 @xierunzi