Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Balloon): strengthen robustness for align, close#517 #524

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

youluna
Copy link
Member

@youluna youluna commented Apr 1, 2019

close #517

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #524 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #524      +/-   ##
=========================================
+ Coverage    91.1%   91.1%   +<.01%     
=========================================
  Files         243     243              
  Lines       13637   13639       +2     
  Branches     4229    4230       +1     
=========================================
+ Hits        12424   12426       +2     
  Misses       1194    1194              
  Partials       19      19
Impacted Files Coverage Δ
src/balloon/balloon.jsx 95.16% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae52bf6...a820b1a. Read the comment docs.

@youluna youluna requested a review from myronliu347 April 1, 2019 02:58
@myronliu347 myronliu347 merged commit 1924b67 into alibaba-fusion:master Apr 1, 2019
@youluna youluna deleted the fix/balloon-align branch September 29, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Balloon]balloon align will crash ui when align is not in enum value
2 participants