Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Balloon]balloon align will crash ui when align is not in enum value #517

Closed
1 task
justnewbee opened this issue Mar 29, 2019 · 1 comment · Fixed by #524
Closed
1 task

[Balloon]balloon align will crash ui when align is not in enum value #517

justnewbee opened this issue Mar 29, 2019 · 1 comment · Fixed by #524
Assignees
@youluna
Labels
🐞 Bug Something isn't working

Comments

@justnewbee
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

1.13.9

Component

Balloon

Environment

any

Reproduction link

http://riddle.alibaba-inc.com/riddles/11fbb549

Steps to reproduce

add align="right" and ui will crash
@justnewbee
Copy link
Author

image

youluna referenced this issue in youluna/next Apr 1, 2019
@youluna
fix(Balloon): strengthen robustness for align, close#517
a820b1a
@youluna youluna added the 🐞 Bug Something isn't working label Apr 1, 2019
@youluna youluna mentioned this issue Apr 1, 2019
Merged
myronliu347 referenced this issue Apr 1, 2019
@myronliu347
Merge pull request #524 from youluna/fix/balloon-align
1924b67 
fix(Balloon): strengthen robustness for align, close#517
@weekly-digest weekly-digest bot mentioned this issue Apr 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youluna youluna

Labels
🐞 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Balloon): strengthen robustness for align, close#517 youluna/next
2 participants
@justnewbee @youluna