DX: Keyreg bytes #522
Merged
DX: Keyreg bytes #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, these fields were required to be base64 encoded, which seems like a strange requirement. Now they may be bytes or b64 strings. Either way, they are stored in the python object as b64 strings to maintain compatibility with our original decision, regardless of how strange it was. Added a few doc string cleanups.
jasonpaulos
approved these changes
Dec 11, 2023
algorandskiy
approved these changes
Dec 11, 2023
| return None | ||
| if isinstance(key, (bytes, bytearray)) and len(key) == size: | ||
| return base64.b64encode(key) | ||
| if len(base64.b64decode(key)) == size: |
There was a problem hiding this comment.
maybe also add isinstance(key, str) otherwise b64decode will probably throw an exception (did not check tho)
There was a problem hiding this comment.
I suppose it will, but that's life in a dynamic language, I think. Before you could have stuffed something crazy in that field, and you'd get an exception somewhere when we tried to serialize. Now it happens earlier, which I think is better.
But I don't want to try to turn Python into Go and insert type checks all over the place.
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the various key-ish fields of a keyreg txn to be bytes
Previously, these fields were required to be base64 encoded, which
seems like a strange requirement.
Added a few doc string cleanups.