Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation: Execution trace (PC/Stack/Scratch) support #505

Merged
merged 17 commits into from
Aug 10, 2023
Merged

Simulation: Execution trace (PC/Stack/Scratch) support #505

merged 17 commits into from
Aug 10, 2023

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Jul 31, 2023 •
edited
Loading

No description provided.

ahangsu
ahangsu commented Jul 31, 2023
View reviewed changes
.test-env Outdated Show resolved Hide resolved
tzaffi
tzaffi reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's still a draft but couldn't help noticing an itsy bitsy nit.

algosdk/v2client/models/simulate_request.py Outdated Show resolved Hide resolved
@ahangsu ahangsu marked this pull request as ready for review August 1, 2023 15:06
jasonpaulos
jasonpaulos reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part looks good I just have some minor comments

algosdk/v2client/models/simulate_request.py Outdated Show resolved Hide resolved
tests/steps/other_v2_steps.py Outdated Show resolved Hide resolved
tests/steps/other_v2_steps.py Outdated Show resolved Hide resolved
@bbroder-algo bbroder-algo merged commit 8f9721b into develop Aug 10, 2023
2 checks passed
This was referenced Aug 16, 2023
Closed
Merged
@gmalouf gmalouf deleted the simulate-basic-pc branch June 5, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzaffi tzaffi tzaffi left review comments

@jasonpaulos jasonpaulos jasonpaulos approved these changes

@bbroder-algo bbroder-algo bbroder-algo approved these changes

Assignees
No one assigned
Labels
New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahangsu @tzaffi @jasonpaulos @bbroder-algo