-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOR REVIEW ONLY: py-algorand-sdk v2.1.0 #446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add setup.py check to circle ci * Fix warnings on version in setup.py * Fail CI check if there are warnings outputted from setup.py check * Fix exit code for circle CI * Use bash * Use negate at front * Escape negate * Escape again * Escape * Add extra step to check setup.py * Remove redundant output * Update .circleci/config.yml Co-authored-by: Michael Diamant <[email protected]> Co-authored-by: Michael Diamant <[email protected]>
* Type Friendly Exports
…oundError and UnderspecifiedRoundError (#438)
* Add disassembly endpoint and implement cucumber test * Add integration tag for tests
* Adding methods to use the simulate endpoint * fix call to sim raw, add response format of msgpack * adding simulate to atc * lint * update names * passing msgpack in both response_format and format * tmp * Remove simulate response, dont bail on would_succeed false * grab the right field out of the txn results * docstrings * provide more information since we get it back from simulate anyway * adding cucumber tests * try to make sandbox run against experimental-api branch * revert env var change * remove extra kwarg * add new test paths, remove json, add docstring * Replace direct method access with method we've already got * adding check for group number * adding tests for empty signer simulation * fix return value for atc simulation * fix return value for atc simulation * Update .test-env * typed return val --------- Co-authored-by: algochoi <[email protected]> Co-authored-by: Bob Broderick <[email protected]>
algobarb
requested review from
ahangsu,
barnjamin,
algochoi,
bbroder-algo,
tzaffi,
a team and
excalq
March 14, 2023 18:18
algochoi
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog and setup.py
version bump looks good to me
ahangsu
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding the simulate, disassembly endpoint support.
What's Changed
Bugfixes
New Features
Enhancements
New Contributors
Full Changelog: v2.0.0...v2.0.1