New Feature: Adding methods to use the simulate endpoint #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnjamin
changed the title
barnjamin
commented
Feb 27, 2023
| @@ -1,6 +1,6 @@ | |||
| # Configs for testing repo download: | |||
| SDK_TESTING_URL="https://github.com/algorand/algorand-sdk-testing" | |||
| SDK_TESTING_BRANCH="master" | |||
| SDK_TESTING_BRANCH="simulate-endpoint-tests" | |||
There was a problem hiding this comment.
remember to change this back
There was a problem hiding this comment.
i looked at the trap ray
bbroder-algo
reviewed
Mar 1, 2023
algochoi
reviewed
Mar 1, 2023
tzaffi
reviewed
Mar 1, 2023
tzaffi
reviewed
Mar 1, 2023
tzaffi
reviewed
Mar 1, 2023
algochoi
reviewed
Mar 3, 2023
| def simulate_atc_failure(context, group, path, message): | ||
| resp: SimulateAtomicTransactionResponse = context.simulate_atc_response | ||
| group_idx: int = int(group) | ||
| fail_path = ",".join( |
There was a problem hiding this comment.
nit:
Suggested change
| fail_path = ",".join( | |
| fail_path: str = ",".join( |
|
|
||
| for i, tx_id in enumerate(self.tx_ids): | ||
| tx_results = [ | ||
| client.pending_transaction_info(tx_id) for tx_id in self.tx_ids |
There was a problem hiding this comment.
caveat/nit: I don't think we need to get the txn info for every transaction, just the ones with method calls (self.method_dict). If the call overhead isn't too bad, we could keep as written in the current PR.
adding tests for empty signer simulation
algochoi
reviewed
Mar 10, 2023
| def sign_transactions( | ||
| self, txn_group: List[transaction.Transaction], indexes: List[int] | ||
| ) -> List[GenericSignedTransaction]: | ||
| stxns = [] |
There was a problem hiding this comment.
- stxns = []
+ stxns: List[GenericSignedTransaction] = []There was a problem hiding this comment.
the linter is complaining error: Incompatible return value type
bbroder-algo
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Simulate endpoint support to algod client
Also added simulate as a method on the AtomicTransactionComposer to allow an api like:
