Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Introduce type linting with mypy #397

Merged
merged 27 commits into from
Dec 7, 2022
Merged

Tests: Introduce type linting with mypy #397

merged 27 commits into from
Dec 7, 2022

Commits on Dec 6, 2022

  1. Add mypy dependency and include it in CI

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    b285255 View commit details
    Browse the repository at this point in the history

  2. Include documentation for type linting

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    2bbc8a3 View commit details
    Browse the repository at this point in the history

  3. Fix type errors in constants.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    ea663f1 View commit details
    Browse the repository at this point in the history

  4. Fix type errors in source_map.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    8df4213 View commit details
    Browse the repository at this point in the history

  5. Fix type errors in dryrun_results.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    1dac040 View commit details
    Browse the repository at this point in the history

  6. Add msgpack-types package

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    80f367f View commit details
    Browse the repository at this point in the history

  7. Fix type errors in template.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    217a022 View commit details
    Browse the repository at this point in the history

  8. Fix type errors in future/template.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    ab70c7d View commit details
    Browse the repository at this point in the history

  9. Fix type errors in future/transaction.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    c1e6504 View commit details
    Browse the repository at this point in the history

  10. Fix type errors in base_type.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6714597 View commit details
    Browse the repository at this point in the history

  11. Fix string format errors with bytestrings

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    1559a62 View commit details
    Browse the repository at this point in the history

  12. Fix type errors in tuple_type.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    3d19951 View commit details
    Browse the repository at this point in the history

  13. Fix type errors in method.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    748db3d View commit details
    Browse the repository at this point in the history

  14. Fix type errors in interface.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    56659b4 View commit details
    Browse the repository at this point in the history

  15. Fix type errors in contract.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    4f40018 View commit details
    Browse the repository at this point in the history

  16. Fix type errors in dryrun.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6acce21 View commit details
    Browse the repository at this point in the history

  17. Fix type errors in atomic_transaction_composer.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    8cf2b06 View commit details
    Browse the repository at this point in the history

  18. Fix formatter errors

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    8dcd5a0 View commit details
    Browse the repository at this point in the history

  19. Fix unsupported types before Python 3.9 

    Some types (such as `list` instead of `List`) were introduced in PEP 585 within Python 3.9 but since `py-algorand-sdk`requires Python 3.8 or later, the explicit types (`List`, `Union`, etc) are necessary for compatibility.
    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    34593aa View commit details
    Browse the repository at this point in the history

  20. Use cast instead of hasattr when inside an issubclass conditional

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    d82af55 View commit details
    Browse the repository at this point in the history

  21. Specify ignored errors

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    ef693d8 View commit details
    Browse the repository at this point in the history

  22. Include mypy configuration 

    This avoids mypy’s fallback behavior which uses the config located in the user’s home directory.
    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6225ff7 View commit details
    Browse the repository at this point in the history

  23. Add py.typed marker so mypy knows we include types

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    c082b1c View commit details
    Browse the repository at this point in the history

  24. Add return type to TransactionSigner.sign_transactions (#3) 

    * Add return type to TransactionSigner.sign_transactions

* Switch back to List

* Fix docstring typo
    @michaeldiamant @jdtzmn
    michaeldiamant authored and jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    41b5a97 View commit details
    Browse the repository at this point in the history

  25. Rename SignedTransaction to GenericSignedTransaction 

    # Conflicts:
#	algosdk/atomic_transaction_composer.py
    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    1b643b0 View commit details
    Browse the repository at this point in the history

  26. Some changes based on mypy: (#1)

    @algochoi @jdtzmn
    algochoi authored and jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    afe769c View commit details
    Browse the repository at this point in the history

  27. Add url metadata to setup.py

    @jdtzmn
    jdtzmn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    24175d3 View commit details
    Browse the repository at this point in the history