Add return type to TransactionSigner.sign_transactions #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
algochoi
reviewed
Nov 23, 2022
algochoi
approved these changes
Nov 28, 2022
|
These changes look good - thank you for opening the PR! |
jdtzmn
pushed a commit
that referenced
this pull request
Nov 29, 2022
* Add return type to TransactionSigner.sign_transactions * Switch back to List * Fix docstring typo
jdtzmn
pushed a commit
that referenced
this pull request
Dec 6, 2022
* Add return type to TransactionSigner.sign_transactions * Switch back to List * Fix docstring typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends algorand#397 to annotate the return type for
TransactionSigner.sign_transactions.