Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Establish code style and fix errors in existing codebase #299

Merged
merged 22 commits into from
Mar 11, 2021
Merged

Establish code style and fix errors in existing codebase #299

merged 22 commits into from
Mar 11, 2021

Commits on Mar 11, 2021

  1. Install eslint and setup configuration

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    57af777 View commit details
    Browse the repository at this point in the history

  2. Run ESLint automatic fixes in src directory

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    cacaecc View commit details
    Browse the repository at this point in the history

  3. Run ESLint automatic fixes in tests directory

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    a9acc8a View commit details
    Browse the repository at this point in the history

  4. Run ESLint automatic fixes in examples directory

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    8e1d423 View commit details
    Browse the repository at this point in the history

  5. Have ESLint ignore dist directory 

    * Run ESLint automatic fixes on all remaining JavaScript files
    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    94c8d04 View commit details
    Browse the repository at this point in the history

  6. Update ESLint configuration to better fit with project's code style

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    20f14e5 View commit details
    Browse the repository at this point in the history

  7. Add Prettier formatter

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    a3082a1 View commit details
    Browse the repository at this point in the history

  8. Run Prettier formatter

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    b57ac21 View commit details
    Browse the repository at this point in the history

  9. Add helpful linting and formatting scripts to package.json

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    4f604c7 View commit details
    Browse the repository at this point in the history

  10. Add recommended editor configuration settings

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    a113e10 View commit details
    Browse the repository at this point in the history

  11. Manually fix linter errors

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    893cd1d View commit details
    Browse the repository at this point in the history

  12. Add precommit hook to format and lint

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    37547b7 View commit details
    Browse the repository at this point in the history

  13. Add CI checks for code style

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    16f710e View commit details
    Browse the repository at this point in the history

  14. Add code style documentation to README.md

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    219a7de View commit details
    Browse the repository at this point in the history

  15. Add secure vars and docker login (#297)

    @onetechnical @jdtzmn
    onetechnical authored and jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    b45a1d0 View commit details
    Browse the repository at this point in the history

  16. Regenerate travis secure vars, don't re-use them (#298)

    @onetechnical @jdtzmn
    onetechnical authored and jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    3f88d38 View commit details
    Browse the repository at this point in the history

  17. Update multisig code (#293) 

    * Remove `MultisigTransaction` overrides that treat non-payment transactions differently

* Add new transaction fields to multisig blobs found in tests and re-sign comparison blobs where needed

* Verify read-only methods on `Transaction` work for `MultisigTransaction`s

* Override inherited `Transaction` methods that mutate multisig transactions to throw an error

* Override `signTxn` on `MultisigTransaction` to throw an error
    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    6d0aa57 View commit details
    Browse the repository at this point in the history

  18. Disable Prettier formatting for certain Uint8Arrays in test files

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    70f0ab2 View commit details
    Browse the repository at this point in the history

  19. Install downgraded es-abstract package to devDependencies to fix Trav… 

    …is errors
    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    3550742 View commit details
    Browse the repository at this point in the history

  20. Merge branch 'develop' into jacob/code-style

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    1e9b675 View commit details
    Browse the repository at this point in the history

  21. Small fixes 

    * Add TypeScript extension to `lint-staged` config file
* Fix Compile class bug that was introduced during linter fixes
    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    b29df2f View commit details
    Browse the repository at this point in the history

  22. Ignore linting and formatting certain cucumber files

    @jdtzmn
    jdtzmn committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    53272b6 View commit details
    Browse the repository at this point in the history